Bug 21570

Summary: Switch two-column templates to Bootstrap grid: Various
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: katrin.fischer, martin.renvoize, nick, testopia
Version: MainKeywords: Academy
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 20654, 21573    
Attachments: Bug 21570: Update two-column templates with Bootstrap grid: Various
Bug 21570: Update two-column templates with Bootstrap grid: Various
Bug 21570: Update two-column templates with Bootstrap grid: Various

Description Owen Leonard 2018-10-15 12:46:52 UTC
These various two-column templates can be updated to use the Bootstrap grid.

 - plugins/plugins-home.tt
 - reviews/reviewswaiting.tt
 - suggestion/suggestion.tt
 - virtualshelves/shelves.tt
Comment 1 Owen Leonard 2018-10-15 13:00:09 UTC
Created attachment 80594 [details] [review]
Bug 21570: Update two-column templates with Bootstrap grid: Various

This patch modifies several assorted templates to use the
Bootstrap grid instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags and "text/css" attributes from <style> tags in the
modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Administration -> Plugins
 - Tools -> Comments
 - Acquisitions -> Suggestions
 - Lists
Comment 2 ByWater Sandboxes 2018-10-18 12:43:46 UTC
Created attachment 80822 [details] [review]
Bug 21570: Update two-column templates with Bootstrap grid: Various

This patch modifies several assorted templates to use the
Bootstrap grid instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags and "text/css" attributes from <style> tags in the
modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Administration -> Plugins
 - Tools -> Comments
 - Acquisitions -> Suggestions
 - Lists

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 3 Jonathan Druart 2018-10-23 15:15:13 UTC
Created attachment 81030 [details] [review]
Bug 21570: Update two-column templates with Bootstrap grid: Various

This patch modifies several assorted templates to use the
Bootstrap grid instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags and "text/css" attributes from <style> tags in the
modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Administration -> Plugins
 - Tools -> Comments
 - Acquisitions -> Suggestions
 - Lists

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Nick Clemens 2018-11-05 14:56:50 UTC
Awesome work all!

Pushed to master for 18.11
Comment 5 Martin Renvoize 2018-11-16 12:29:47 UTC
Enhancement, will not be backported to 18.05.x series.