Bug 21680

Summary: Remove dead code C4::Accounts::fixaccounts
Product: Koha Reporter: Josef Moravec <josef.moravec>
Component: Architecture, internals, and plumbingAssignee: Josef Moravec <josef.moravec>
Status: CLOSED FIXED QA Contact: Martin Renvoize <martin.renvoize>
Severity: trivial    
Priority: P5 - low CC: fridolin.somers, martin.renvoize, nick
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 14825    
Attachments: Bug 21680: Remove dead code - C4::Accounts::fixaccounts
Bug 21680: Remove dead code - C4::Accounts::fixaccounts

Description Josef Moravec 2018-10-26 09:26:53 UTC
This sub is even commented out for years.
Comment 1 Josef Moravec 2018-10-26 09:29:35 UTC
Created attachment 81259 [details] [review]
Bug 21680: Remove dead code - C4::Accounts::fixaccounts

Test plan:

git grep fixacccounts
-- without patch there are 3 occurences
-- with patch - no occurence of fixaccounts

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 2 Martin Renvoize 2018-10-26 14:31:20 UTC
Created attachment 81295 [details] [review]
Bug 21680: Remove dead code - C4::Accounts::fixaccounts

Test plan:

git grep fixacccounts
-- without patch there are 3 occurences
-- with patch - no occurence of fixaccounts

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 3 Martin Renvoize 2018-10-26 14:32:18 UTC
Well found.. you are entirely right, I can't find a single case across the whole codebase where this is used now.

Going straight for PQA.
Comment 4 Nick Clemens (kidclamp) 2018-10-26 17:25:35 UTC
Awesome work all!

Pushed to master for 18.11
Comment 5 Martin Renvoize 2018-11-08 15:18:57 UTC
Pushed to 18.05.x for 18.05.06.. always good to trim the fat.
Comment 6 Fridolin Somers 2018-11-28 10:23:14 UTC
I prefer not to impact 17.11.x