Description
Katrin Fischer
2019-01-17 16:36:32 UTC
Created attachment 84148 [details] [review] Bug 22156: Subscription result list sorts on "checkbox" by default This patch adds default sorting by title to the subscription search results list. Previously no default sort was defined, so it defaulted to sorting by the first column in the table. To test, apply the patch and go to Serials. - Perform a search of subscriptions which will return multiple results. - Confirm that the table of open subscriptions is sorted by default by title ascending. - Confirm the same for the table of closed subscriptions. Created attachment 84149 [details] [review] Bug 22156: (17.11.x) Subscription result list sorts on "checkbox" by default This patch adds default sorting by title to the subscription search results list. Previously no default sort was defined, so it defaulted to sorting by the first column in the table. To test, apply the patch and go to Serials. - Perform a search of subscriptions which will return multiple results. - Confirm that the table of open subscriptions is sorted by default by title ascending. - Confirm the same for the table of closed subscriptions. Created attachment 84163 [details] Bug 22156: Open subs Created attachment 84164 [details] Bug 22156: Closed subs As seen from the two recently added attachments, it doesn't look like the code is working as intended. The subscriptions on both the open and closed subscriptions tables are not arranged by default by title ascending. (In reply to Ethan from comment #5) > The subscriptions on both the open and closed > subscriptions tables are not arranged by default by title ascending. The sorting in the screenshots is correct. When sorting by title we ignore articles like "A" and "The." Created attachment 85193 [details] [review] Bug 22156: Subscription result list sorts on "checkbox" by default This patch adds default sorting by title to the subscription search results list. Previously no default sort was defined, so it defaulted to sorting by the first column in the table. To test, apply the patch and go to Serials. - Perform a search of subscriptions which will return multiple results. - Confirm that the table of open subscriptions is sorted by default by title ascending. - Confirm the same for the table of closed subscriptions. Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos@inLibro.com> Created attachment 85194 [details] [review] Bug 22156: (17.11.x) Subscription result list sorts on "checkbox" by default This patch adds default sorting by title to the subscription search results list. Previously no default sort was defined, so it defaulted to sorting by the first column in the table. To test, apply the patch and go to Serials. - Perform a search of subscriptions which will return multiple results. - Confirm that the table of open subscriptions is sorted by default by title ascending. - Confirm the same for the table of closed subscriptions. Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos@inLibro.com> Created attachment 85207 [details] [review] Bug 22156: Subscription result list sorts on "checkbox" by default This patch adds default sorting by title to the subscription search results list. Previously no default sort was defined, so it defaulted to sorting by the first column in the table. To test, apply the patch and go to Serials. - Perform a search of subscriptions which will return multiple results. - Confirm that the table of open subscriptions is sorted by default by title ascending. - Confirm the same for the table of closed subscriptions. Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 85208 [details] [review] Bug 22156: (17.11.x) Subscription result list sorts on "checkbox" by default This patch adds default sorting by title to the subscription search results list. Previously no default sort was defined, so it defaulted to sorting by the first column in the table. To test, apply the patch and go to Serials. - Perform a search of subscriptions which will return multiple results. - Confirm that the table of open subscriptions is sorted by default by title ascending. - Confirm the same for the table of closed subscriptions. Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Awesome work all! Pushed to master for 19.05 Pushed to 18.11.x for 18.11.04 backported to 18.05.x for 18.05.11 |