Bug 22215

Summary: table_borrowers name is inconsistent with other tables
Product: Koha Reporter: Nick Clemens (kidclamp) <nick>
Component: CirculationAssignee: Nick Clemens (kidclamp) <nick>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: gmcharlt, jonathan.druart, katrin.fischer, kyle.m.hall, kyle, m.de.rooy
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36614
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 17353    
Bug Blocks:    

Description Nick Clemens (kidclamp) 2019-01-28 12:41:39 UTC
This table should be renamed more like patrons-table or patron-results-table
Comment 1 Marcel de Rooy 2019-05-13 08:21:36 UTC
(In reply to Nick Clemens from comment #0)
> This table should be renamed more like patrons-table or patron-results-table

patrons-table ?
You mean: patrons ?
That is a not an operation that I would recommend to do just before release.
Comment 2 Katrin Fischer 2019-05-13 10:58:35 UTC
I think he refers to the names we use to refer tables to in columns configuration. So this is just a selector for JS.
Comment 3 Owen Leonard 2019-05-13 12:01:26 UTC
I don't feel strongly about this because it's not a clear identifier no matter what the id is. The include file containing the table is called "circ-patron-search-results.inc," which is fairly explanatory. Maybe that should be the table name too?
Comment 4 Katrin Fischer 2019-05-13 12:02:33 UTC
I like having it contain circ to differentiate from the normal patron search. Maybe circ-patron-search ? Results seems not strictly necessary.