Summary: | Comment on column suggestions.STATUS is not complete | ||
---|---|---|---|
Product: | Koha | Reporter: | Josef Moravec <josef.moravec> |
Component: | Developer documentation | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | 1joynelson, david, katrin.fischer, lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | String patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.05.00, 19.11.06, 19.05.11
|
|
Attachments: |
Bug 22335: Fix comment on suggestions.STATUS in kohastructure.sql
Bug 22335: Fix comment on suggestions.STATUS in kohastructure.sql Bug 22335: Fix comment on suggestions.STATUS in kohastructure.sql Bug 22335: Fix comment on suggestions.STATUS in kohastructure.sql |
Description
Josef Moravec
2019-02-14 08:58:33 UTC
Created attachment 102795 [details] [review] Bug 22335: Fix comment on suggestions.STATUS in kohastructure.sql The description on STATUS was incomplete, missing 2 status and the SUGGEST_STATUS category. To test: - Later this will show up in schema.koha-community.org, but for now it can only be verified reading the patch. The patch no longer applies (if that is required): Applying: Bug 22335: Fix comment on suggestions.STATUS in kohastructure.sql Using index info to reconstruct a base tree... M installer/data/mysql/kohastructure.sql Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/kohastructure.sql CONFLICT (content): Merge conflict in installer/data/mysql/kohastructure.sql error: Failed to merge in the changes. Patch failed at 0001 Bug 22335: Fix comment on suggestions.STATUS in kohastructure.sql Happy to sign-off otherwise. Created attachment 103883 [details] [review] Bug 22335: Fix comment on suggestions.STATUS in kohastructure.sql The description on STATUS was incomplete, missing 2 status and the SUGGEST_STATUS category. To test: - Later this will show up in schema.koha-community.org, but for now it can only be verified reading the patch. Rebased - Joubu added the new archived column just below the line I fixed, causing the conflict. Created attachment 103884 [details] [review] Bug 22335: Fix comment on suggestions.STATUS in kohastructure.sql The description on STATUS was incomplete, missing 2 status and the SUGGEST_STATUS category. To test: - Later this will show up in schema.koha-community.org, but for now it can only be verified reading the patch. Signed-off-by: David Nind <david@davidnind.com> Created attachment 104295 [details] [review] Bug 22335: Fix comment on suggestions.STATUS in kohastructure.sql The description on STATUS was incomplete, missing 2 status and the SUGGEST_STATUS category. To test: - Later this will show up in schema.koha-community.org, but for now it can only be verified reading the patch. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Nice work everyone! Pushed to master for 20.05 Backported to 19.11.x for 19.11.06 backported to 19.05.x for 19.05.11 |