Bug 22476

Summary: MarkLostItemsAsReturned has wrong defaults for new installs
Product: Koha Reporter: Nick Clemens <nick>
Component: DatabaseAssignee: Nick Clemens <nick>
Status: CLOSED FIXED QA Contact: Martin Renvoize <martin.renvoize>
Severity: major    
Priority: P5 - low CC: fridolin.somers, lucas, margaret, martin.renvoize, wizzyrea
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 19287    
Bug Blocks:    
Attachments: Bug 22476: Correct default for MarkLostItemsAsReturned
Bug 22476: Correct default for MarkLostItemsAsReturned
Bug 22476: Correct default for MarkLostItemsAsReturned

Description Nick Clemens 2019-03-07 16:43:11 UTC
bug 19287 added 'pendingreserves' as an option for MarkLostItemsAsReturned, but did not add it to the options for the syspref in sysprefs.sql

Additionally, the values should be comma separated, not pipe
Comment 1 Nick Clemens 2019-03-07 16:49:55 UTC
Created attachment 86303 [details] [review]
Bug 22476: Correct default for MarkLostItemsAsReturned

To test:
Install a new db (reset_all)
Verify the sysprefs is set as expected
Comment 2 Bin Wen 2019-03-08 20:43:39 UTC
Created attachment 86404 [details] [review]
Bug 22476: Correct default for MarkLostItemsAsReturned

Signed-off-by: Bin Wen <bin.wen@inlibro.com>
Comment 3 Martin Renvoize 2019-03-12 12:13:36 UTC
Created attachment 86514 [details] [review]
Bug 22476: Correct default for MarkLostItemsAsReturned

Signed-off-by: Bin Wen <bin.wen@inlibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize 2019-03-12 12:13:55 UTC
Trivial patch, Passing QA
Comment 5 Nick Clemens 2019-03-15 12:49:30 UTC
Awesome work all!

Pushed to master for 19.05
Comment 6 Martin Renvoize 2019-03-19 09:40:18 UTC
Pushed to 18.11.x for 18.11.04
Comment 7 Lucas Gass 2019-03-19 23:19:20 UTC
backported to 18.05.x for 18.05.11
Comment 8 Fridolin Somers 2019-03-26 06:24:58 UTC
Depends on Bug 19287 not in 17.11.x