Bug 22498

Summary: Can not select any funds for invoice adjustments
Product: Koha Reporter: Nick Clemens (kidclamp) <nick>
Component: AcquisitionsAssignee: Nick Clemens (kidclamp) <nick>
Status: CLOSED FIXED QA Contact: Josef Moravec <josef.moravec>
Severity: major    
Priority: P5 - low CC: fridolin.somers, josef.moravec, lucas, martin.renvoize
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 14850    
Bug Blocks: 22296    
Attachments: Bug 22498: Rename variable for budgets loop for invoice adjustments
Bug 22498: Rename variable for budgets loop for invoice adjustments
Bug 22498: Rename variable for budgets loop for invoice adjustments
Bug 22498: Rename variable for budgets loop for invoice adjustments

Description Nick Clemens (kidclamp) 2019-03-12 13:14:55 UTC
Bug 14850 renamed budgets_loop to budgets but did not update the variables for invoice adjustments
Comment 1 Nick Clemens (kidclamp) 2019-03-12 13:26:18 UTC
Created attachment 86531 [details] [review]
Bug 22498: Rename variable for budgets loop for invoice adjustments

To test:
1 - Try to add some adjustments to an invoice (receive shipments, create invoice, click 'finish receiving')
2 - Note the fund dropdown has only 'No fund'
3 - Apply patch
4 - Refresh page
5 - Note you can now select funds, hooray!
Comment 2 Nick Clemens (kidclamp) 2019-03-12 17:03:17 UTC
Created attachment 86546 [details] [review]
Bug 22498: Rename variable for budgets loop for invoice adjustments

To test:
1 - Try to add some adjustments to an invoice (receive shipments, create invoice, click 'finish receiving')
2 - Note the fund dropdown has only 'No fund'
3 - Apply patch
4 - Refresh page
5 - Note you can now select funds, hooray!
Comment 3 Martin Renvoize 2019-03-13 11:23:27 UTC
Created attachment 86567 [details] [review]
Bug 22498: Rename variable for budgets loop for invoice adjustments

To test:
1 - Try to add some adjustments to an invoice (receive shipments, create invoice, click 'finish receiving')
2 - Note the fund dropdown has only 'No fund'
3 - Apply patch
4 - Refresh page
5 - Note you can now select funds, hooray!

Signed-off-by: Janet McGowan <janet.mcgowan@ptfs-europe.com>
Comment 4 Martin Renvoize 2019-03-13 11:24:44 UTC
Just doing the honours of uploading Janets signed patch for her.. sandboxes don't like signing of dependants.
Comment 5 Josef Moravec 2019-03-14 10:28:49 UTC
Created attachment 86595 [details] [review]
Bug 22498: Rename variable for budgets loop for invoice adjustments

To test:
1 - Try to add some adjustments to an invoice (receive shipments, create invoice, click 'finish receiving')
2 - Note the fund dropdown has only 'No fund'
3 - Apply patch
4 - Refresh page
5 - Note you can now select funds, hooray!

Signed-off-by: Janet McGowan <janet.mcgowan@ptfs-europe.com>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 6 Nick Clemens (kidclamp) 2019-03-15 12:50:21 UTC
Awesome work all!

Pushed to master for 19.05
Comment 7 Martin Renvoize 2019-03-19 09:30:35 UTC
Pushed to 18.11.x for 18.11.04
Comment 8 Lucas Gass 2019-03-19 22:56:00 UTC
18.05.x is missing 14850 dependency. won't backport