Description
Hayley Pelham
2019-03-26 01:12:54 UTC
Created attachment 86997 [details] [review] Bug 22579: Add syspref to toggle dropdown/links in Z39.50 search results This patch reduces the number of clicks to use 'Card preview' functionality without removing the work done to condense the three links into a menu in Bug 19939 which is displayed by default (and when the syspref is disabled). Test plan: 1) Apply the patch 2) In Cataloging click the New from Z39.50/SRU button and search for a term that will produce results 3) In the results window, note that the actions column contains a dropdown for each row which contains three links. 4) Change the Replacez3950CatalogingActionMenuWithLinks to 'Do' 5) Complete step 2 again, and instead note that the actions column now contains three links, Card preview, MARC preview, Import 6) Verify that each of the links work as expected 7) Sign off! Sponsored-by: Horowhenua Library Trust Do they know they can click anywhere in the row to trigger the menu? A system preference seems like overkill to me, but that's certainly an opinion informed by a different workflow. (In reply to Owen Leonard from comment #2) > Do they know they can click anywhere in the row to trigger the menu? A > system preference seems like overkill to me, but that's certainly an opinion > informed by a different workflow. I think the problem is less with the placement of the menu, rather the fact that they now have to trigger it before they can access their most commonly used option when they didn't have to before. We didn't want to revert the change that was made, so we decided that a system preference would be the easiest way to include this fix, and make life easier for the library. Could we use a split button with import being the default? (like receive in the subscription search list) I also share the feeling that a pref might be a little overkill here when it seems more like a usability issue. (In reply to Katrin Fischer from comment #4) > Could we use a split button with import being the default? (like receive in > the subscription search list) > > I also share the feeling that a pref might be a little overkill here when it > seems more like a usability issue. A split button could work, but the library are wanting Card Preview to be the easiest to access. Would it be acceptable to have Card Preview as the main option, and MARC preview and import be in the dropdown part? Hi, this patch on latest master make z39.50 broken. Explain video is here: http://recordit.co/zgDQVntvhg Sorry folks, my fault. Nothing broken. It's between chair nad keyboard :-) Patch works. Can I set it as SO? Or some more folow-ups coming? (In reply to Michal Denar from comment #8) > Patch works. Can I set it as SO? Or some more folow-ups coming? Hi Michal, I think I need to change some things to align with the comments I've received first. Thanks for taking a look! Setting to assigned I have a couple of suggestions for how we could fix this. Split button, with import being the main action AND make the title clickable, to the card or marc preview in a modal like it does now - whichever your client prefers since presumably they are the ones paying for the dev. In this case, I don't think we'd need a syspref. If someone in the future wants to change what the title links to there, they can add the syspref. :) Ping me if you have questions. Cheers, Liz Created attachment 101783 [details] [review] Bug 22579: Split actions in z3950 search results into a split button Where 'Import' is the main button and the two card previews are in the dropdown Also show Card preview when clicking on title of record To test: 1) Go to Cataloguing -> New from Z39.50/SRU 2) Search for a term that will produce results 3) Once results are shown, notice the split button 4) Click anywhere on results rows. Confirm the dropdown menu still shows when you click anywhere, as normal 5) Confirm clicking the title pops up the Card preview 6) Confirm Import is the main button in the actions and still works as expected Sponsored-by: Horowhenua Library Trust This is almost ready, but I am struggling to get rid of the whitespace showing between the two buttons in the button group. If anyone knows what I'm doing wrong here please let me know! (In reply to Aleisha Amohia from comment #12) > This is almost ready, but I am struggling to get rid of the whitespace > showing between the two buttons in the button group. If anyone knows what > I'm doing wrong here please let me know! Sneakily adding Owen for advice....please? Created attachment 104998 [details] [review] Bug 22579: Split actions in z3950 search results into a split button Where 'Import' is the main button and the two card previews are in the dropdown Also show Card preview when clicking on title of record To test: 1) Go to Cataloguing -> New from Z39.50/SRU 2) Search for a term that will produce results 3) Once results are shown, notice the split button 4) Click anywhere on results rows. Confirm the dropdown menu still shows when you click anywhere, as normal 5) Confirm clicking the title pops up the Card preview 6) Confirm Import is the main button in the actions and still works as expected Sponsored-by: Horowhenua Library Trust Rebased, but still super stuck on that whitespace! Owen, any ideas? (In reply to Aleisha Amohia from comment #15) > still super stuck on that whitespace! I have no idea why the whitespace is an issue here when it doesn't seem to be a problem elsewhere. But removing the whitespace fixes it so let's do that! (In reply to Owen Leonard from comment #16) > (In reply to Aleisha Amohia from comment #15) > > still super stuck on that whitespace! > > I have no idea why the whitespace is an issue here when it doesn't seem to > be a problem elsewhere. But removing the whitespace fixes it so let's do > that! That's precisely the problem :) I can't seem the remove the whitespace. It's not in the HTML or the JS so I don't know what's adding it between the Import button and the dropdown button. Created attachment 105054 [details] [review] Bug 22579: (follow-up) Remove problematic whitespace This patch removes some whitespace from the template which was causing display problems with the "Import" split button. Aleisha, does this patch work for you? It looks good to me in Firefox and Chromium on OSX Created attachment 105055 [details] [review] Bug 22579: Split actions in z3950 search results into a split button Where 'Import' is the main button and the two card previews are in the dropdown Also show Card preview when clicking on title of record To test: 1) Go to Cataloguing -> New from Z39.50/SRU 2) Search for a term that will produce results 3) Once results are shown, notice the split button 4) Click anywhere on results rows. Confirm the dropdown menu still shows when you click anywhere, as normal 5) Confirm clicking the title pops up the Card preview 6) Confirm Import is the main button in the actions and still works as expected Sponsored-by: Horowhenua Library Trust Created attachment 105056 [details] [review] Bug 22579: (follow-up) Remove problematic whitespace This patch removes some whitespace from the template which was causing display problems with the "Import" split button. (In reply to Owen Leonard from comment #19) > Aleisha, does this patch work for you? It looks good to me in Firefox and > Chromium on OSX Ahh of course, such an annoyingly simple fix! Thanks Owen. Have amended the first patch because there was some weird stuff happening with opening and closing the dropdown. This is now ready for testing. Created attachment 113206 [details] [review] Bug 22579: Split actions in z3950 search results into a split button Where 'Import' is the main button and the two card previews are in the dropdown Also show Card preview when clicking on title of record To test: 1) Go to Cataloguing -> New from Z39.50/SRU 2) Search for a term that will produce results 3) Once results are shown, notice the split button 4) Click anywhere on results rows. Confirm the dropdown menu still shows when you click anywhere, as normal 5) Confirm clicking the title pops up the Card preview 6) Confirm Import is the main button in the actions and still works as expected Sponsored-by: Horowhenua Library Trust Created attachment 113207 [details] [review] Bug 22579: (follow-up) Remove problematic whitespace This patch removes some whitespace from the template which was causing display problems with the "Import" split button. Did you see bug 23302 ? We are working on the same thing. (In reply to Marcel de Rooy from comment #25) > Did you see bug 23302 ? > We are working on the same thing. Hi Marcel, this bug was reported and had a patch earlier than Bug 23302, so I think Bug 23302 is the duplicate and should be closed. |