Bug 22655

Summary: Add setup of a hold rule to the onboarding tool
Product: Koha Reporter: Hayley Pelham <hayleypelham>
Component: Installation and upgrade (web-based installer)Assignee: Aleisha Amohia <aleisha>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: 1joynelson, aleisha, dcook, gmcharlt, martin.renvoize
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: Sponsored Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
20.05.00
Attachments: Bug 22655: Adding holds rules to Onboarding tool
Bug 22655: Adding holds rules to Onboarding tool
Bug 22655: Adding holds rules to Onboarding tool

Description Hayley Pelham 2019-04-07 22:45:49 UTC
Currently, when doing a fresh install of Koha, no Holds rules are set during the Onboarding process. This means that users testing Holds or new users to Koha have to set up Hold rules in the Tools before placing any Holds. We should allow users to set up default Hold rule while setting up the Circulation rules.
Comment 1 Aleisha Amohia 2020-02-13 02:50:18 UTC
Created attachment 98785 [details] [review]
Bug 22655: Adding holds rules to Onboarding tool

This patch adds the following fields to the circ rule step in the
onboarding tool:
- holds allowed (total)
- holds allowed (daily)
- holds per record (count)

To test:
1) Apply patch, drop and recreate database, restart memcached and refresh page
2) Go through the installer and get to the final step of the onboarding
tool
3) Confirm the above fields are now available to set in your circulation
rule
4) Save and log in to Koha
5) Go to Admin -> Circ and fines rules
6) Confirm the fields saved correctly

Sponsored-by: Catalyst IT
Comment 2 Owen Leonard 2020-02-14 17:06:00 UTC
Created attachment 98981 [details] [review]
Bug 22655: Adding holds rules to Onboarding tool

This patch adds the following fields to the circ rule step in the
onboarding tool:
- holds allowed (total)
- holds allowed (daily)
- holds per record (count)

To test:
1) Apply patch, drop and recreate database, restart memcached and refresh page
2) Go through the installer and get to the final step of the onboarding
tool
3) Confirm the above fields are now available to set in your circulation
rule
4) Save and log in to Koha
5) Go to Admin -> Circ and fines rules
6) Confirm the fields saved correctly

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Martin Renvoize 2020-02-21 08:38:35 UTC
Created attachment 99358 [details] [review]
Bug 22655: Adding holds rules to Onboarding tool

This patch adds the following fields to the circ rule step in the
onboarding tool:
- holds allowed (total)
- holds allowed (daily)
- holds per record (count)

To test:
1) Apply patch, drop and recreate database, restart memcached and refresh page
2) Go through the installer and get to the final step of the onboarding
tool
3) Confirm the above fields are now available to set in your circulation
rule
4) Save and log in to Koha
5) Go to Admin -> Circ and fines rules
6) Confirm the fields saved correctly

Sponsored-by: Catalyst IT
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize 2020-02-21 08:38:57 UTC
Works well, passes QA tests..

Passing QA
Comment 5 Martin Renvoize 2020-02-21 16:08:25 UTC
Nice work everyone!

Pushed to master for 20.05
Comment 6 Alex Buckley 2020-02-26 00:18:46 UTC
*** Bug 19378 has been marked as a duplicate of this bug. ***
Comment 7 Joy Nelson 2020-03-13 00:54:09 UTC
enhancement not backported to 19.11.x