Summary: | tmpl_process3.pl warns on a semmingly valid construct | ||
---|---|---|---|
Product: | Koha | Reporter: | Galen Charlton <gmcharlt> |
Component: | I18N/L10N | Assignee: | Galen Charlton <gmcharlt> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | minor | ||
Priority: | P3 | CC: | katrin.fischer, oleonard |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
Description
Chris Cormack
2010-05-21 00:48:45 UTC
Does this bug still exist with Template Toolkit? I have retested this and our unit tests catch both cases: <p [% IF ( loggedinusername ) %]class="something"[% END %] />Test</p> <p [% IF ( loggedinusername ) %]class="something"[% END %]/>Test</p> 1..1 not ok 1 - TT syntax: not using TT directive within HTML tag # Failed test 'TT syntax: not using TT directive within HTML tag' # at xt/tt_valid.t line 55. # Files list: # opac-tmpl/prog/en/modules/opac-main.tt: 39, 42 # Looks like you failed 1 test of 1. The test succeeds on current master and we will catch new instances. Even with those constructs updating and installing German templates generates no visible errrors for me: perl translate update de-DE perl translate instal de-DE The translated templates are ok in this case, but I believe there were problems with other similar constructs causing translation issues. I am marking this resolved fixed. Please reopen if I missed something. |