Bug 23139

Summary: Koha::SharedContent->get_sharing_url is not used
Product: Koha Reporter: Martin Renvoize <martin.renvoize>
Component: Mana-kbAssignee: Bugs List <koha-bugs>
Status: RESOLVED INVALID QA Contact:
Severity: normal    
Priority: P5 - low CC: jonathan.druart
Version: unspecified   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:

Description Martin Renvoize 2019-06-17 17:38:30 UTC
The `get_sharing_url` method in Koha::SharedContent is currently only used in the unit tests. We should either convert code to use this routine or remove it.

Personally, I think it could perhaps serve a similar use to shib_ok in C4::Auth_with_shibboleth in that we could add a cached config check (which would hit the Mana server to test it's actually there) and then return undef for failure or pass through the mana base url otherwise.
Comment 1 Jonathan Druart 2019-06-20 00:26:43 UTC
It's also used in Koha::SharedContent::build_request

187     my $mana_url = get_sharing_url();
Comment 2 Katrin Fischer 2023-10-08 10:51:02 UTC
(In reply to Jonathan Druart from comment #1)
> It's also used in Koha::SharedContent::build_request
> 
> 187     my $mana_url = get_sharing_url();

Closing.