Bug 23162

Summary: Cannot copy a notice if independent branches enabled and not a superlibrarian
Product: Koha Reporter: Nick Clemens (kidclamp) <nick>
Component: ToolsAssignee: Bugs List <koha-bugs>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: aleisha, ellawipatene, jonathan.druart, katrin.fischer
Version: MainKeywords: Academy
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:

Description Nick Clemens (kidclamp) 2019-06-19 16:18:41 UTC
We forget to set the branch to current branch I guess

To recreate:
 1 - Be a superlibrarian (you all are anyways!)
 2 - Go to Tools->notices and slips
 3 - Note you see notices and can copy them to other branches to edit
 4 - Now enabled independent branches
 5 - It all still works
 6 - Stop being a superlibrarian (i.e. create a patron with permissions for  notices, but not superlibrarian)
 7 - Go to Tools->notices and slips
 8 - Note the 'copy' button doesn't have a drop down to select branch
 9 - Click it, you can edit
10 - Try to save - Alert:A letter with the code 'ACCTDETAILS' already exists for 'undefined'.
Comment 1 Jonathan Druart 2019-06-19 19:39:51 UTC
What should we do? Remove the Copy button?
Comment 2 Katrin Fischer 2019-07-13 13:01:45 UTC
2 ideas here:

- Don't show the copy button if indybranches is active and user is not superlibraian.
- Show copy for notices for All branches and allow to copy to the user's branch
Comment 3 Aleisha Amohia 2021-01-19 21:38:04 UTC
Is this still relevant?