Summary: | Branch Transfer Limits branch_transfer_limits.pl DBI to Koha::Object, fix variable semantics | ||
---|---|---|---|
Product: | Koha | Reporter: | Olli-Antti Kivilahti <olli-antti.kivilahti> |
Component: | Circulation | Assignee: | Olli-Antti Kivilahti <olli-antti.kivilahti> |
Status: | Failed QA --- | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | gmcharlt, joonas.kylmala, katrin.fischer, kyle.m.hall |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 23343 | ||
Bug Blocks: | 23344 | ||
Attachments: | Bug 23342 - Branch Transfer Limits branch_transfer_limits.pl DBI to Koha::Object, fix variable semantics |
Description
Olli-Antti Kivilahti
2019-07-18 16:47:46 UTC
Created attachment 91604 [details] [review] Bug 23342 - Branch Transfer Limits branch_transfer_limits.pl DBI to Koha::Object, fix variable semantics branch_transfer_limits.pl uses DBI SQL statements in the controller. Replace those with Koha::Objects. change term 'branchcode' to 'fromBranch' to clarify what is the purpose of the branchcode. Prepare for more BranchTransferLimit authorised value limiting types. Sponsored-by: The National Library of Finland Hi there, can you please provide a test plan? Doesn't apply anymore and would have to be split into separate patches for each individual change described in the patch message as this patch combines multiple changes. |