Bug 24111

Summary: Incorrect "Can't create any orders" alert
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: AcquisitionsAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED WONTFIX QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: martin.renvoize, stina.hallin
Version: unspecified   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 6994    
Bug Blocks:    
Attachments: Bug 24111: Remove incorrect "Can't create any orders" alert

Description Jonathan Druart 2019-11-26 08:44:26 UTC
It happens to see "You can't create any orders unless you first define a budget and a fund" when adding a new order.

The test on neworderbiblio.pl is not the same as other pages. We should test if the logged in user can use the budget, not if they are the owner.
Comment 1 Jonathan Druart 2019-11-26 08:47:03 UTC
Created attachment 95811 [details] [review]
Bug 24111: Remove incorrect "Can't create any orders" alert

It happens to see "You can't create any orders unless you first define a
budget and a fund" when adding a new order.

The test on neworderbiblio.pl is not the same as other pages. We should
test if the logged in user can use the budget, not if they are the
owner.

Test plan:
0/ Add an owner to all of your funds
1/ Create an order from an existing record
=> Without this patch you should see the alert at the bottom of the
result list
=> With this patch applied you should not see it

QA will compare with the 2 other occurrences, in acqui/basket.pl and
acqui/booksellers.pl
Comment 2 Stina Hallin 2020-02-07 13:06:36 UTC
Hello, I cannot recreate the error message in the sandbox. I can recreate it in our own test Koha on version 19.05.04. Of course there can be differences in our setups. I have tried the sandbox both with and without the patch.
Comment 3 Martin Renvoize 2020-02-10 16:05:40 UTC
`error: sha1 information is lacking or useless (acqui/neworderbiblio.pl).`.. any chance of a rebase on this one Jonathan?
Comment 4 Jonathan Druart 2020-02-11 09:46:10 UTC
acqui/neworderbiblio.pl has been removed by bug 24347 and should have fixed the issue reported initially.