Bug 24417

Summary: Charges/Fees.t is failing randomly
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Test SuiteAssignee: Chris Cormack <chris>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: 1joynelson, victor
Version: unspecified   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25729
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 25551    

Description Jonathan Druart 2020-01-14 09:47:36 UTC
I cannot recreate locally, but Jenkins has a failing test on Koha_19.11_U18, run 29:

koha_1       |     #   Failed test 'Daily rental charge calculated correctly with finesCalendar = noFinesWhenClosed and closed Monday'
koha_1       |     #   at t/db_dependent/Koha/Charges/Fees.t line 362.
koha_1       |     #          got: '6'
koha_1       |     #     expected: '5'
koha_1       | 
koha_1       |     #   Failed test 'Hourly rental charge calculated correctly with finesCalendar = noFinesWhenClosed and closed Monday (96h - 24h * 0.25u)'
koha_1       |     #   at t/db_dependent/Koha/Charges/Fees.t line 396.
koha_1       |     #          got: '24'
koha_1       |     #     expected: '18'
koha_1       |     # Looks like you failed 2 tests of 7.
koha_1       | 
koha_1       | #   Failed test 'accumulate_rentalcharge tests'
koha_1       | #   at t/db_dependent/Koha/Charges/Fees.t line 403.
Comment 1 Joy Nelson 2020-01-21 18:40:34 UTC
Let me know if something needs doing on 19.11.x branch.
Comment 2 Victor Grousset/tuxayo 2020-06-12 02:58:57 UTC
Same failure, Koha_19.05_U18
https://jenkins.koha-community.org/view/19.05/job/Koha_19.05_U18/234/consoleText
Comment 3 Victor Grousset/tuxayo 2020-06-12 12:23:31 UTC Comment hidden (obsolete)
Comment 4 Victor Grousset/tuxayo 2020-06-12 12:24:07 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2020-06-12 12:57:59 UTC Comment hidden (obsolete)
Comment 6 Victor Grousset/tuxayo 2020-06-12 16:34:04 UTC Comment hidden (obsolete)
Comment 7 Victor Grousset/tuxayo 2020-06-12 16:39:00 UTC
comments related to bug 25729 were marked as obsolete

(In reply to Victor Grousset/tuxayo from comment #2)
> Same failure, Koha_19.05_U18
> https://jenkins.koha-community.org/view/19.05/job/Koha_19.05_U18/234/
> consoleText

This is still valid even if I couldn't reproduce locally.

koha_1       |     #   Failed test 'Daily rental charge calculated correctly with finesCalendar = noFinesWhenClosed and closed Thursday'
koha_1       |     #   at t/db_dependent/Koha/Charges/Fees.t line 362.
koha_1       |     #          got: '6'
koha_1       |     #     expected: '5'
koha_1       | 
koha_1       |     #   Failed test 'Hourly rental charge calculated correctly with finesCalendar = noFinesWhenClosed and closed Thursday (96h - 24h * 0.25u)'
koha_1       |     #   at t/db_dependent/Koha/Charges/Fees.t line 396.
koha_1       |     #          got: '24'
koha_1       |     #     expected: '18'
koha_1       |     # Looks like you failed 2 tests of 7.
koha_1       | 
koha_1       | #   Failed test 'accumulate_rentalcharge tests'
koha_1       | #   at t/db_dependent/Koha/Charges/Fees.t line 403.