Bug 25590

Summary: Street number is missing from alternate address in the OPAC
Product: Koha Reporter: David Roberts <david.roberts>
Component: OPACAssignee: Katrin Fischer <katrin.fischer>
Status: RESOLVED FIXED QA Contact: Martin Renvoize <martin.renvoize>
Severity: normal    
Priority: P5 - low CC: martin.renvoize
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.05
Attachments: Bug 25590: B_streetnumber is missing from opac-memberentry.pl
Bug 25590: B_streetnumber is missing from opac-memberentry.pl
Bug 25590: Street number is missing from the alternate address in the OPAC
Bug 25590: Street number is missing from the alternate address in the OPAC
Bug 25590: Street number is missing from the alternate address in the OPAC

Description David Roberts 2020-05-22 21:00:02 UTC
If a patron adds an alternate address to their patron record in the OPAC, there is no option to enter a street number. This field is available in the staff client.
Comment 1 David Roberts 2020-05-22 21:19:48 UTC Comment hidden (obsolete)
Comment 2 Lucas Gass 2020-05-22 21:36:52 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2020-06-21 13:55:23 UTC
Hi David,
the sequence of fields is not right when AddressFormat = German is selected. That's because we put the street number after the street name here. If you check how this is handled for the Main address, I think this could be copied for the Alternate address without too much headache.
Comment 4 Katrin Fischer 2020-06-21 13:56:02 UTC
Another thing, but more for dicussion: Should we amend the *unwanted* preferences to add B_streetnumber on update to avoid behavior change?
Comment 5 Katrin Fischer 2023-02-26 11:36:48 UTC
Looking at bug 32663, I realized this is still valid. Maybe time to have another look.
Comment 6 Katrin Fischer 2023-02-26 12:11:08 UTC
Hope it's ok, I am stealing this one with a new patch.
Comment 7 Katrin Fischer 2023-02-26 12:11:57 UTC
Created attachment 147422 [details] [review]
Bug 25590: Street number is missing from the alternate address in the OPAC

This patch adds the street number field to the alternate address
section in the OPAC, matching the layout of the address in the
staff interface.

To test:

1) Check that you are unable to add a street number to the Alternate
address when logged into the OPAC
2) Apply the patch
3) Check that you can now add and edit the streetnumber field.
4) Check that it also works correctly in patron self-registration.
5) Make the field mandatory and verify this works as expected
   (PatronSelfRegistrationBorrowerMandatoryField and PatronSelfModificationBorrowerMandatoryField)
6) Hide the field from the form
   (PatronSelfRegistrationBorrowerUnwantedField and PatronSelfModificationBorrowerUnwantedField)
7) Change the AddressFormat system preference to German
8) Verify that the street number field moved after the first address line matching
   the first address in the form.
Comment 8 Owen Leonard 2023-02-27 12:19:34 UTC
Created attachment 147438 [details] [review]
Bug 25590: Street number is missing from the alternate address in the OPAC

This patch adds the street number field to the alternate address
section in the OPAC, matching the layout of the address in the
staff interface.

To test:

1) Check that you are unable to add a street number to the Alternate
address when logged into the OPAC
2) Apply the patch
3) Check that you can now add and edit the streetnumber field.
4) Check that it also works correctly in patron self-registration.
5) Make the field mandatory and verify this works as expected
   (PatronSelfRegistrationBorrowerMandatoryField and PatronSelfModificationBorrowerMandatoryField)
6) Hide the field from the form
   (PatronSelfRegistrationBorrowerUnwantedField and PatronSelfModificationBorrowerUnwantedField)
7) Change the AddressFormat system preference to German
8) Verify that the street number field moved after the first address line matching
   the first address in the form.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 9 Martin Renvoize 2023-03-15 18:15:50 UTC
Created attachment 148243 [details] [review]
Bug 25590: Street number is missing from the alternate address in the OPAC

This patch adds the street number field to the alternate address
section in the OPAC, matching the layout of the address in the
staff interface.

To test:

1) Check that you are unable to add a street number to the Alternate
address when logged into the OPAC
2) Apply the patch
3) Check that you can now add and edit the streetnumber field.
4) Check that it also works correctly in patron self-registration.
5) Make the field mandatory and verify this works as expected
   (PatronSelfRegistrationBorrowerMandatoryField and PatronSelfModificationBorrowerMandatoryField)
6) Hide the field from the form
   (PatronSelfRegistrationBorrowerUnwantedField and PatronSelfModificationBorrowerUnwantedField)
7) Change the AddressFormat system preference to German
8) Verify that the street number field moved after the first address line matching
   the first address in the form.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 10 Martin Renvoize 2023-03-15 18:16:55 UTC
Great to see this taken care of :)

Passing QA
Comment 11 Tomás Cohen Arazi 2023-04-03 10:30:05 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 12 Jacob O'Mara 2023-04-16 17:24:02 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.