Summary: | Wrong CSS float on 'Visibility' in framework edition | ||
---|---|---|---|
Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
Component: | System Administration | Assignee: | Fridolin Somers <fridolin.somers> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | andrewfh, caroline.cyr-la-rose, david, gmcharlt, oleonard |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/admin/marc_subfields_structure.pl | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This fixes the display of the 'Visibility' label when editing subfields for a framework. The label is now aligned correctly with the other labels.
|
Version(s) released in: |
21.05.00,20.11.02
|
Attachments: |
Screenshot without patch
Bug 27310: Remove CSS float on 'Visibility' in framework edition Bug 27310: Remove CSS float on 'Visibility' in framework edition Bug 27310: Remove CSS float on 'Visibility' in framework edition |
Description
Fridolin Somers
2020-12-29 10:54:45 UTC
Created attachment 114717 [details]
Screenshot without patch
Created attachment 114718 [details] [review] Bug 27310: Remove CSS float on 'Visibility' in framework edition In administration > framework edition > subfield edition, 'Visibility' label as a CSS rule float none. This seems obsolete, removing it will align label like others. Test plan : 1) Go to Administration 2) Edit any framework 3) Edit any subfield 4) Look at 'Visibility' => Without patch label is sticked to the left => With patch label postion is like others Created attachment 114742 [details] [review] Bug 27310: Remove CSS float on 'Visibility' in framework edition In administration > framework edition > subfield edition, 'Visibility' label as a CSS rule float none. This seems obsolete, removing it will align label like others. Test plan : 1) Go to Administration 2) Edit any framework 3) Edit any subfield 4) Look at 'Visibility' => Without patch label is sticked to the left => With patch label postion is like others Signed-off-by: David Nind <david@davidnind.com> Tested on Ubuntu 18.04 with Google Chrome, Firefox and Firefox Developer Edition. With the patch applied the Visibility are aligns nicely like all the other options. Created attachment 114765 [details] [review] Bug 27310: Remove CSS float on 'Visibility' in framework edition In administration > framework edition > subfield edition, 'Visibility' label as a CSS rule float none. This seems obsolete, removing it will align label like others. Test plan : 1) Go to Administration 2) Edit any framework 3) Edit any subfield 4) Look at 'Visibility' => Without patch label is sticked to the left => With patch label postion is like others Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Nice little patch, thx Frido! Pushed to master for 21.05, thanks to everybody involved! Pushed to 20.11.x for 20.11.02 Doesn't apply cleanly to 20.05, please rebase if needed Its realy minor, I mark as resolved |