Description
Jonathan Druart
2021-03-03 15:39:58 UTC
Created attachment 117800 [details] [review] Bug 27851: Add tests Created attachment 117801 [details] [review] Bug 27851: Add Koha::Old::Checkouts->filter_by_todays_checkins The logic for this code is handled at two different places (and in 2 different ways). Better to centralize and provide tests Created attachment 117802 [details] [review] Bug 27851: Use filter_by_todays_checkins in printslip.pl Test plan: No regression from bug 12224 test plan Created attachment 117803 [details] [review] Bug 27851: Use filter_by_todays_checkins in members/readingrec.pl Test plan: Do some checkouts Checkin with different return dates (several today however) Check the circulation history and confirm that the checkout list is correct Created attachment 117822 [details] [review] Bug 27851: Add Koha::Old::Checkouts->filter_by_todays_checkins The logic for this code is handled at two different places (and in 2 different ways). Better to centralize and provide tests Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 117823 [details] [review] Bug 27851: Use filter_by_todays_checkins in printslip.pl Test plan: No regression from bug 12224 test plan Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 117824 [details] [review] Bug 27851: Use filter_by_todays_checkins in members/readingrec.pl Test plan: Do some checkouts Checkin with different return dates (several today however) Check the circulation history and confirm that the checkout list is correct Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 117825 [details] [review] Bug 27851: Add tests Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 117826 [details] [review] Bug 27851: Add Koha::Old::Checkouts->filter_by_todays_checkins The logic for this code is handled at two different places (and in 2 different ways). Better to centralize and provide tests Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 117827 [details] [review] Bug 27851: Use filter_by_todays_checkins in printslip.pl Test plan: No regression from bug 12224 test plan Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 117828 [details] [review] Bug 27851: Use filter_by_todays_checkins in members/readingrec.pl Test plan: Do some checkouts Checkin with different return dates (several today however) Check the circulation history and confirm that the checkout list is correct Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Tests pass, I checked the behaviour or the checkin slip, the reading history and also the behavior for the AnonymousPatron. Created attachment 117836 [details] [review] Bug 27851: Add tests Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 117837 [details] [review] Bug 27851: Add Koha::Old::Checkouts->filter_by_todays_checkins The logic for this code is handled at two different places (and in 2 different ways). Better to centralize and provide tests Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 117838 [details] [review] Bug 27851: Use filter_by_todays_checkins in printslip.pl Test plan: No regression from bug 12224 test plan Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 117839 [details] [review] Bug 27851: Use filter_by_todays_checkins in members/readingrec.pl Test plan: Do some checkouts Checkin with different return dates (several today however) Check the circulation history and confirm that the checkout list is correct Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Passing QA :) Pushed to master for 21.05, thanks to everybody involved! |