Summary: | QotD CSV upload JavaScript errors | ||
---|---|---|---|
Product: | Koha | Reporter: | Lucas Gass <lucas> |
Component: | Tools | Assignee: | Lucas Gass <lucas> |
Status: | CLOSED FIXED | QA Contact: | Joonas Kylmälä <joonas.kylmala> |
Severity: | minor | ||
Priority: | P5 - low | CC: | fridolin.somers, jonathan.druart, joonas.kylmala |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This patch handles malformed CSV errors by producing a warning on the page letting users know that the CSV filed uploaded has errors.
|
Version(s) released in: |
21.05.00
|
Bug Depends on: | 27251 | ||
Bug Blocks: | |||
Attachments: |
Bug 27869: let user know something went wrong with csv upload
bad_example.csv Bug 27869: let user know something went wrong with csv upload Bug 27869: let user know something went wrong with csv upload |
Description
Lucas Gass
2021-03-04 19:25:18 UTC
Created attachment 117760 [details] [review] Bug 27869: let user know something went wrong with csv upload To test: -attempt to upload a malformed CSV file -nothing happens, check the console and see the error: Uncaught TypeError: arrData[(arrData.length - 1)] is undefined -apply patch -try again -now you should at least see a warning that something went wrong -attempt to upload a good CSV file, it should work (In reply to Lucas Gass from comment #1) > -attempt to upload a malformed CSV file Can you suggest how to make it malformed? Created attachment 117875 [details]
bad_example.csv
(In reply to Owen Leonard from comment #2) > (In reply to Lucas Gass from comment #1) > > -attempt to upload a malformed CSV file > > Can you suggest how to make it malformed? I have attached an example file. Created attachment 117949 [details] [review] Bug 27869: let user know something went wrong with csv upload To test: -attempt to upload a malformed CSV file -nothing happens, check the console and see the error: Uncaught TypeError: arrData[(arrData.length - 1)] is undefined -apply patch -try again -now you should at least see a warning that something went wrong -attempt to upload a good CSV file, it should work Signed-off-by: David Nind <david@davidnind.com> Created attachment 119071 [details] [review] Bug 27869: let user know something went wrong with csv upload To test: -attempt to upload a malformed CSV file -nothing happens, check the console and see the error: Uncaught TypeError: arrData[(arrData.length - 1)] is undefined -apply patch -try again -now you should at least see a warning that something went wrong -attempt to upload a good CSV file, it should work Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Pushed to master for 21.05, thanks to everybody involved! |