Summary: | Internal server error when placing hold if previously uploaded records have no item type set | ||
---|---|---|---|
Product: | Koha | Reporter: | Cindy Murdock Ames <cmurdock> |
Component: | Hold requests | Assignee: | Bugs List <koha-bugs> |
Status: | NEW --- | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | gmcharlt, jonathan.druart |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
Description
Cindy Murdock Ames
2021-03-17 19:38:20 UTC
Itemtype is mandatory, it must be a valid value defined in the system. You can find the problematic records running the following maintenance script: % perl misc/maintenance/search_for_data_inconsistencies.pl That is true, but shouldn't the MARC staging tool set it to the default value to help prevent this? In my default framework there is a default value set. (In reply to Cindy Murdock Ames from comment #2) > That is true, but shouldn't the MARC staging tool set it to the default > value to help prevent this? In my default framework there is a default > value set. The default values only work on adding a new record, if you overwrite them to say "empty" they are not going to be set automatically to a value. I think we could maybe get away with this change in behavior if we also said it has to be a mandatory field that cannot be empty or even limit to item type? Otherwise there are probably use cases where this might be an unwanted behavior. I would suggest to set 952$y to the default value you want. Could that work for you? Yes, that would work. 952y is also set as mandatory in my default framework, I would guess that it is in most libraries' frameworks, so a check to see if it was mandatory and if so making sure it has data would work too, if I'm understanding things here correctly. |