Summary: | OPAC detail page contains incorrect Bootstrap classes (20.05.x) | ||
---|---|---|---|
Product: | Koha | Reporter: | Lucas Gass <lucas> |
Component: | OPAC | Assignee: | Lucas Gass <lucas> |
Status: | CLOSED FIXED | QA Contact: | Tomás Cohen Arazi <tomascohen> |
Severity: | normal | ||
Priority: | P5 - low | CC: | amitddng135, andrewfh, jonathan.druart, lisettepalouse+koha, tomascohen, victor |
Version: | 20.05 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This patch fixes some bad Bootstrap classes introduced to 20.05 via a bad backport.
|
Version(s) released in: |
20.05.11
|
Bug Depends on: | 27029 | ||
Bug Blocks: | |||
Attachments: |
Bug 28021: Fix Bootstrap classes
Bug 28021: Fix Bootstrap classes Bug 28021: Fix Bootstrap classes Bug 28021: Fix Bootstrap classes |
Description
Lucas Gass
2021-03-22 22:33:42 UTC
Created attachment 118629 [details] [review] Bug 28021: Fix Bootstrap classes To test: -be on 20.05.x -go to any OPAC detail page -the maincontent stretchs across the entire page -the action buttons (place hold, save to lists, print, ect) are pushed to the bottom of the page -apply patch and reload page -things are better Created attachment 118634 [details] [review] Bug 28021: Fix Bootstrap classes To test: -be on 20.05.x -go to any OPAC detail page -the maincontent stretchs across the entire page -the action buttons (place hold, save to lists, print, ect) are pushed to the bottom of the page -apply patch and reload page -things are better Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Created attachment 118635 [details] [review] Bug 28021: Fix Bootstrap classes To test: -be on 20.05.x -go to any OPAC detail page -the maincontent stretchs across the entire page -the action buttons (place hold, save to lists, print, ect) are pushed to the bottom of the page -apply patch and reload page -things are better Work OK. Created attachment 119320 [details] [review] Bug 28021: Fix Bootstrap classes To test: -be on 20.05.x -go to any OPAC detail page -the maincontent stretchs across the entire page -the action buttons (place hold, save to lists, print, ect) are pushed to the bottom of the page -apply patch and reload page -things are better Signed-off-by: Amit Gupta <amitddng135@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Nice catch, Lucas. Moving to 20.05 RMaint queue. Pushed to 20.05.x for 20.05.11, thanks! Missing dependencies for 19.11.x, it shouldn't be affected, no backport. |