Summary: | Wrong plack condition in C4/Auth_with_shibboleth.pm | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | andrewfh, fridolin.somers, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
21.05.00,20.11.06,20.05.12,19.11.19
|
|
Attachments: |
Bug 28367: Fix plack condition in C4/Auth_with_shibboleth.pm
Bug 28367: (follow-up) Fix plack condition in C4/Auth_with_shibboleth.pm |
Description
Jonathan Druart
2021-05-18 08:42:33 UTC
Created attachment 121094 [details] [review] Bug 28367: Fix plack condition in C4/Auth_with_shibboleth.pm C4/Auth_with_shibboleth.pm has: if ( any { /(^psgi\.|^plack\.)/i } keys %ENV ) When others have: if ( any { /(^psgi\.|^plack\.)/i } keys %ENV ) This has been highlighted by https://gitlab.com/koha-community/koha-testing-docker/-/issues/249 that introduces a PLACK_WORKERS env vars, and t/Auth_with_shibboleth.t was failing with # Failed test 'checkpw_shib tests' # at t/Auth_with_shibboleth.t line 335. Invalid parameter passed, categorycode= does not exist# Looks like your test exited with 255 just after 5. Pushed to master for 21.05.00 Created attachment 121099 [details] [review] Bug 28367: (follow-up) Fix plack condition in C4/Auth_with_shibboleth.pm There were 2 occurrences! Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> We should create a method C4::Context->is_plack() Pushed to 20.11.x for 20.11.06 Pushed to 20.05.x for 20.05.12 Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. Got a request for this so: Backported: Pushed to 19.11.x branch for 19.11.18 Actually it was for v19.11.18-2, a micro release to contain this last moment patch. And I mixed up the patches. It will be for v19.11.19 |