Bug 28708

Summary: fr-CA localization file
Product: Koha Reporter: Caroline Cyr La Rose <caroline.cyr-la-rose>
Component: I18N/L10NAssignee: Caroline Cyr La Rose <caroline.cyr-la-rose>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: f.demians, jonathan.druart, katrin.fischer, lucas, marjorie.barry-vila, philippe.blouin
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00
Attachments: Bug 28708 : fr-CA localization file
Bug 28708: fr-CA localization file
Bug 28708: fr-CA localization file
Bug 28708: fr-CA localization file

Description Caroline Cyr La Rose 2021-07-13 16:29:23 UTC
I saw some other languages had localization files for specific system preferences. I had my own file before, but now I can share most of it (some things are specific to our organization).
Comment 1 Caroline Cyr La Rose 2021-07-13 16:32:44 UTC
Created attachment 122807 [details] [review]
Bug 28708 : fr-CA localization file

This patch adds a custom.sql file in localization/fr-CA.
Comment 2 Jonathan Druart 2021-12-15 08:00:40 UTC
Sorry Caroline, I haven't seen this one before.

IMO the localization should not include your own (or company) preferences.
See bellow.


+UPDATE systempreferences SET value = 'fre|eng' WHERE variable = 'AdvancedSearchLanguages';
+UPDATE systempreferences SET value = 'CA' WHERE variable = 'AmazonLocale';
+UPDATE systempreferences SET value = 'père|mère|grand-parent|tuteur légal|autre' WHERE variable = 'borrowerRelationship';
+UPDATE systempreferences SET value = 'M.|Mme|Mx' WHERE variable = 'BorrowersTitles';

ok

+UPDATE systempreferences SET value = 365 WHERE variable = 'ConfirmFutureHolds';

nok

+UPDATE systempreferences SET value = 'FR' WHERE variable = 'CurencyFormat';
+UPDATE systempreferences SET value = 'iso' WHERE variable = 'dateformat';

ok

+UPDATE systempreferences SET value = 1 where variable ='FilterBeforeOverdueReport';
+UPDATE systempreferences SET value = 'production' WHERE variable = 'finesMode';
+UPDATE systempreferences SET value = 365 WHERE variable = 'HoldsToPullStartDate';

nok

+UPDATE systempreferences SET value = 'fr' WHERE variable = 'KohaManualLanguage';
+UPDATE systempreferences SET value = 'fr-CA,en' WHERE variable = 'language';
+UPDATE systempreferences SET value = 'http://www.marc21.ca/MaJ/BIB/B{FIELD}.pdf' WHERE variable = 'MarcFieldDocURL';
+UPDATE systempreferences SET value = 'pdfformat::layout3pagesfr' WHERE variable = 'OrderPdfFormat';
+UPDATE systempreferences SET value = 'fr-CA,en' WHERE variable = 'OPACLanguages';

ok

+UPDATE systempreferences SET value = 0 WHERE variable = 'OpacAllowPublicListCreation';
+UPDATE systempreferences SET value = 1 WHERE variable = 'opaclanguagesdisplay';
+UPDATE systempreferences SET value = '' WHERE variable = 'OpacNav';
+UPDATE systempreferences SET value = '' WHERE variable = 'OpacNavBottom';
+UPDATE systempreferences SET value = 1 WHERE variable = 'OpacSuppression';

nok

+UPDATE systempreferences SET value = '0|0.05|0.09975|0.14975' WHERE variable = 'TaxRates';

ok

+UPDATE systempreferences SET value = 1 WHERE variable = 'useDefaultReplacementCost'; 

nok

Does it make sense?
Comment 3 Katrin Fischer 2021-12-15 10:44:42 UTC
I think these would be ok:

+UPDATE systempreferences SET value = '' WHERE variable = 'OpacNav';
+UPDATE systempreferences SET value = '' WHERE variable = 'OpacNavBottom';

The default is in English - I think in the German file some have been translated but setting them to empty is valid too.
Comment 4 Jonathan Druart 2021-12-15 10:54:46 UTC
(In reply to Katrin Fischer from comment #3)
> I think these would be ok:
> 
> +UPDATE systempreferences SET value = '' WHERE variable = 'OpacNav';
> +UPDATE systempreferences SET value = '' WHERE variable = 'OpacNavBottom';
> 
> The default is in English - I think in the German file some have been
> translated but setting them to empty is valid too.

Those 2 have been removed anyway :)
Comment 5 Caroline Cyr La Rose 2022-08-16 20:52:36 UTC
Created attachment 139215 [details] [review]
Bug 28708: fr-CA localization file

This patch adds a custom.sql file in localization/fr-CA.
Comment 6 Katrin Fischer 2022-08-21 21:35:35 UTC
Created attachment 139560 [details] [review]
Bug 28708: fr-CA localization file

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 7 Kyle M Hall 2022-09-02 14:47:21 UTC
Created attachment 140160 [details] [review]
Bug 28708: fr-CA localization file

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 8 Tomás Cohen Arazi 2022-09-07 20:30:41 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 9 Lucas Gass 2022-10-31 19:30:46 UTC
Enhancement will not be included in 22.05.x series