Summary: | Unused opac/rss directory can be removed | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | kyle |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
21.11.00
|
|
Attachments: |
Bug 28893: Remove unused opac/rss directory
Bug 28893: Remove unused opac/rss directory Bug 28893: Remove unused opac/rss directory |
Description
Jonathan Druart
2021-08-25 08:49:20 UTC
Created attachment 124081 [details] [review] Bug 28893: Remove unused opac/rss directory RSS feeds are now generated using opac/opac-search.pl (format=rss). But prior to commit 09df0de35fcb5b1645490bd3ec9d9a77ec7923a1 Removing obsolete RSS <link> tags and the scripts it was using opac/opac-rss.pl, which used opac/rss The directory should have been removed by this commit. Test plan: Confirm that this directory is useless and can be removed. Created attachment 124088 [details] [review] Bug 28893: Remove unused opac/rss directory RSS feeds are now generated using opac/opac-search.pl (format=rss). But prior to commit 09df0de35fcb5b1645490bd3ec9d9a77ec7923a1 Removing obsolete RSS <link> tags and the scripts it was using opac/opac-rss.pl, which used opac/rss The directory should have been removed by this commit. Test plan: Confirm that this directory is useless and can be removed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Doing some investigation here... does someone know what misc/rss is for? Created attachment 124219 [details] [review] Bug 28893: Remove unused opac/rss directory RSS feeds are now generated using opac/opac-search.pl (format=rss). But prior to commit 09df0de35fcb5b1645490bd3ec9d9a77ec7923a1 Removing obsolete RSS <link> tags and the scripts it was using opac/opac-rss.pl, which used opac/rss The directory should have been removed by this commit. Test plan: Confirm that this directory is useless and can be removed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> (In reply to Katrin Fischer from comment #3) > Doing some investigation here... does someone know what misc/rss is for? Where do you see it? Sorry, left out "cronjobs": https://git.koha-community.org/Koha-community/Koha/src/branch/master/misc/cronjobs/rss I was just wondering as I can't remember seeing that one in documentation. From the original author in the README quite an old piece of Koha :) Discussion should totally happen elsewhere. (In reply to Katrin Fischer from comment #6) > Sorry, left out "cronjobs": > https://git.koha-community.org/Koha-community/Koha/src/branch/master/misc/ > cronjobs/rss > > I was just wondering as I can't remember seeing that one in documentation. > From the original author in the README quite an old piece of Koha :) > Discussion should totally happen elsewhere. I never used this script prior to today, but they don't seem to work great. mostReserved.conf is using items.reserves which is not implemented, lastAcquired.conf generates a list of <item> <title>, by </title> <link>http://kohadev.myDNSname.org:8080/cgi-bin/koha/opac-detail.pl?biblionumber=435</link> </item> Pushed to master for 21.11, thanks to everybody involved! |