Description
Caroline Cyr La Rose
2021-08-25 18:16:28 UTC
Same problem in German btw. Good! that means it will benefit more than one language :D Created attachment 124089 [details] [review] Bug 28898: Context for translation: term (word) vs. term (semester) This patch add context to the term Term in the context of course reserves. To test: 0- Apply patch Set up course reserves 1- Enable UseCourseReserves 2- Create at least one authorized value for DEPARTMENT 3- Create at least one authorized value for TERM 4- Create a course 5- Add at least one item to the course Check the terms: 6- Go to the OPAC 7- Go to Course reserves ** 8- In the list of courses, check the Term column heading 9- Go to the staff interface 10- Go to Course reserves ** 11- In the list of courses, check the Term column heading 12- Click on the course name ** 13- Check the Term line in the course description Add a new language (fr-CA in the example, change for whatever language code you want) 14- In a terminal, run gulp po:create --lang fr-CA 15- Then, run gulp po:update --lang fr-CA 16- In system preferences, enable the new language in language and OpacLanguages 17- Switch the language in staff interface and OPAC Change the translations 18- In your favourite text editor, open fr-CA-messages.po 19- Find the string 'msgctxt Semester' 20- Enter a word in msgstr 21- Save the file 22- In a terminal, go to misc/translator 23- Run ./translate install fr-CA Check the translations 24- Redo the steps to check the terms (6-16) and make sure the terms in steps 8, 11, and 13 are changed for the word you put in step 20. 25- Optionally, check the following pages to make sure the terms are not the word you put in step 20 (these pages shouldn't have been changed) - opac-tags (your account > your tags) - opac-authorities (search for an authority in Authority search) - review (tags in staff interface) I apologize for the gazillion steps in the test plan >_< I hope I did everything right, it's been a while. Let me know if anything needs changing. Caroline Created attachment 124212 [details] [review] Bug 28898: Context for translation: term (word) vs. term (semester) This patch add context to the term Term in the context of course reserves. To test: 0- Apply patch Set up course reserves 1- Enable UseCourseReserves 2- Create at least one authorized value for DEPARTMENT 3- Create at least one authorized value for TERM 4- Create a course 5- Add at least one item to the course Check the terms: 6- Go to the OPAC 7- Go to Course reserves ** 8- In the list of courses, check the Term column heading 9- Go to the staff interface 10- Go to Course reserves ** 11- In the list of courses, check the Term column heading 12- Click on the course name ** 13- Check the Term line in the course description Add a new language (fr-CA in the example, change for whatever language code you want) 14- In a terminal, run gulp po:create --lang fr-CA 15- Then, run gulp po:update --lang fr-CA 16- In system preferences, enable the new language in language and OpacLanguages 17- Switch the language in staff interface and OPAC Change the translations 18- In your favourite text editor, open fr-CA-messages.po 19- Find the string 'msgctxt Semester' 20- Enter a word in msgstr 21- Save the file 22- In a terminal, go to misc/translator 23- Run ./translate install fr-CA Check the translations 24- Redo the steps to check the terms (6-16) and make sure the terms in steps 8, 11, and 13 are changed for the word you put in step 20. 25- Optionally, check the following pages to make sure the terms are not the word you put in step 20 (these pages shouldn't have been changed) - opac-tags (your account > your tags) - opac-authorities (search for an authority in Authority search) - review (tags in staff interface) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 124213 [details] [review] Bug 28898: (follow-up) Remove comment lines before PROCESS statements Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 124214 [details] [review] Bug 28898: (follow-up) Add context to some more occurrences of Term in course reserves Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Hi Caroline, I used to have to rename these with jQuery, so quite keen on these patches. I have found some more "Term:" in the course reserves templates, would you check my follow-up and maybe sign off on them? Created attachment 124438 [details] [review] Bug 28898: Context for translation: term (word) vs. term (semester) This patch add context to the term Term in the context of course reserves. To test: 0- Apply patch Set up course reserves 1- Enable UseCourseReserves 2- Create at least one authorized value for DEPARTMENT 3- Create at least one authorized value for TERM 4- Create a course 5- Add at least one item to the course Check the terms: 6- Go to the OPAC 7- Go to Course reserves ** 8- In the list of courses, check the Term column heading 9- Go to the staff interface 10- Go to Course reserves ** 11- In the list of courses, check the Term column heading 12- Click on the course name ** 13- Check the Term line in the course description Add a new language (fr-CA in the example, change for whatever language code you want) 14- In a terminal, run gulp po:create --lang fr-CA 15- Then, run gulp po:update --lang fr-CA 16- In system preferences, enable the new language in language and OpacLanguages 17- Switch the language in staff interface and OPAC Change the translations 18- In your favourite text editor, open fr-CA-messages.po 19- Find the string 'msgctxt Semester' 20- Enter a word in msgstr 21- Save the file 22- In a terminal, go to misc/translator 23- Run ./translate install fr-CA Check the translations 24- Redo the steps to check the terms (6-16) and make sure the terms in steps 8, 11, and 13 are changed for the word you put in step 20. 25- Optionally, check the following pages to make sure the terms are not the word you put in step 20 (these pages shouldn't have been changed) - opac-tags (your account > your tags) - opac-authorities (search for an authority in Authority search) - review (tags in staff interface) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 124439 [details] [review] Bug 28898: (follow-up) Remove comment lines before PROCESS statements Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 124440 [details] [review] Bug 28898: (follow-up) Add context to some more occurrences of Term in course reserves Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> This was my first time signing off a patch of a set and I ran into errors. I hope I did everything ok. Created attachment 124741 [details] [review] Bug 28898: Context for translation: term (word) vs. term (semester) This patch add context to the term Term in the context of course reserves. To test: 0- Apply patch Set up course reserves 1- Enable UseCourseReserves 2- Create at least one authorized value for DEPARTMENT 3- Create at least one authorized value for TERM 4- Create a course 5- Add at least one item to the course Check the terms: 6- Go to the OPAC 7- Go to Course reserves ** 8- In the list of courses, check the Term column heading 9- Go to the staff interface 10- Go to Course reserves ** 11- In the list of courses, check the Term column heading 12- Click on the course name ** 13- Check the Term line in the course description Add a new language (fr-CA in the example, change for whatever language code you want) 14- In a terminal, run gulp po:create --lang fr-CA 15- Then, run gulp po:update --lang fr-CA 16- In system preferences, enable the new language in language and OpacLanguages 17- Switch the language in staff interface and OPAC Change the translations 18- In your favourite text editor, open fr-CA-messages.po 19- Find the string 'msgctxt Semester' 20- Enter a word in msgstr 21- Save the file 22- In a terminal, go to misc/translator 23- Run ./translate install fr-CA Check the translations 24- Redo the steps to check the terms (6-16) and make sure the terms in steps 8, 11, and 13 are changed for the word you put in step 20. 25- Optionally, check the following pages to make sure the terms are not the word you put in step 20 (these pages shouldn't have been changed) - opac-tags (your account > your tags) - opac-authorities (search for an authority in Authority search) - review (tags in staff interface) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Created attachment 124742 [details] [review] Bug 28898: (follow-up) Remove comment lines before PROCESS statements Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Created attachment 124743 [details] [review] Bug 28898: (follow-up) Add context to some more occurrences of Term in course reserves Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Pushed to master for 21.11, thanks to everybody involved! I'm a bit confused by this one. Does it show "Term" in the English UI but "Semester" in the translation file? While a "semester" is a "term", not all terms are semesters. https://en.wikipedia.org/wiki/Academic_term French should be the same as English with trimestres, semestres, etc. I'm not across Koha's translation idiosyncrasies but I can't see how "semester" would be the right choice here. Happy for someone to explain it though as I imagine I'm just confused. For context, here in Sydney Australia some universities use semesters and others use trimesters for their academic terms. While back in western Canada we had quarter terms in high school. (In reply to David Cook from comment #17) > I'm a bit confused by this one. > > Does it show "Term" in the English UI but "Semester" in the translation file? The strings with the same context will be translated together with the context showing as a "hint" when translating. You still see "term". The English GUI is not changed by this patch set at all. The main point here is not semester vs. term, but more: term vs. search terms. We have "term" showing up in context of search and in the course reserves module. The context is different, but without this patch you can't differentiate. In German the term for 'time' and term for 'words' are completely different words and this patch allows to use different translations. (In reply to Katrin Fischer from comment #19) > (In reply to David Cook from comment #17) > > I'm a bit confused by this one. > > > > Does it show "Term" in the English UI but "Semester" in the translation file? > > The strings with the same context will be translated together with the > context showing as a "hint" when translating. You still see "term". The > English GUI is not changed by this patch set at all. > > The main point here is not semester vs. term, but more: term vs. search > terms. We have "term" showing up in context of search and in the course > reserves module. The context is different, but without this patch you can't > differentiate. In German the term for 'time' and term for 'words' are > completely different words and this patch allows to use different > translations. Thanks for the explanation, Katrin. I figured it must be something like that but it wasn't obvious at a glance. |