Summary: | Make GoogleOpenIDConnect options consistent in the OPAC | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | david, jonathan.druart, kyle |
Version: | Main | Keywords: | Manual |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This enhancement improves the consistency of the OPAC login forms when using Google OpenID Connect. A "Log in with Google" button now appears above the Koha login form when logging in from the home page, "Log in to your account" in the navigation menu, and when accessed directly (/cgi-bin/koha/opac-user.pl).
|
Version(s) released in: |
21.11.00
|
Bug Depends on: | 10988 | ||
Bug Blocks: | |||
Attachments: |
Bug 29006: Make GoogleOpenIDConnect options consistent in the OPAC
Bug 29006: Make GoogleOpenIDConnect options consistent in the OPAC Bug 29006: Make GoogleOpenIDConnect options consistent in the OPAC Bug 29006: Make GoogleOpenIDConnect options consistent in the OPAC |
Description
Owen Leonard
2021-09-13 14:45:05 UTC
Created attachment 124862 [details] [review] Bug 29006: Make GoogleOpenIDConnect options consistent in the OPAC This patch makes modifications to OPAC templates to make the Google login options more consistent. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - In the staff interface, enable the GoogleOpenIDConnect preference, and populate the GoogleOAuth2ClientID the GoogleOAuth2ClientSecret with values (they don't need to be valid). - On the OPAC main page you should see a "Log in with Google" button above the Koha login form. - If you click the "Log in to your account" link at the top of the page you should see a "Log in with Google" button in the modal window - If you navigate directly to /cgi-bin/koha/opac-user.pl when not logged in you should see the same "Log in with Google" button on that page. - In each case the Google button should point to /cgi-bin/koha/svc/auth/googleopenidconnect - If you disable GoogleOpenIDConnect the buttons should disappear. Hi Owen. After applying the patch, updating the css, flush_memcached, restart_all, and a fresh browser with the cache cleared I'm not seeing the changes come through in the OPAC (the login form on the main page and in the header). It's probably something I haven't done.... David You populated these preferences? GoogleOAuth2ClientID GoogleOAuth2ClientSecret And turned this one on? GoogleOpenIDConnect Do you have any missing modules under About -> Perl modules? Created attachment 125177 [details] [review] Bug 29006: Make GoogleOpenIDConnect options consistent in the OPAC This patch makes modifications to OPAC templates to make the Google login options more consistent. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - In the staff interface, enable the GoogleOpenIDConnect preference, and populate the GoogleOAuth2ClientID the GoogleOAuth2ClientSecret with values (they don't need to be valid). - On the OPAC main page you should see a "Log in with Google" button above the Koha login form. - If you click the "Log in to your account" link at the top of the page you should see a "Log in with Google" button in the modal window - If you navigate directly to /cgi-bin/koha/opac-user.pl when not logged in you should see the same "Log in with Google" button on that page. - In each case the Google button should point to /cgi-bin/koha/svc/auth/googleopenidconnect - If you disable GoogleOpenIDConnect the buttons should disappear. Signed-off-by: David Nind <david@davidnind.com> (In reply to Owen Leonard from comment #3) > You populated these preferences? > > GoogleOAuth2ClientID > GoogleOAuth2ClientSecret > > And turned this one on? > > GoogleOpenIDConnect > > Do you have any missing modules under About -> Perl modules? All worked perfectly today! Must have been me not doing something right..¯\_(ツ)_/¯ Created attachment 125314 [details] [review] Bug 29006: Make GoogleOpenIDConnect options consistent in the OPAC This patch makes modifications to OPAC templates to make the Google login options more consistent. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - In the staff interface, enable the GoogleOpenIDConnect preference, and populate the GoogleOAuth2ClientID the GoogleOAuth2ClientSecret with values (they don't need to be valid). - On the OPAC main page you should see a "Log in with Google" button above the Koha login form. - If you click the "Log in to your account" link at the top of the page you should see a "Log in with Google" button in the modal window - If you navigate directly to /cgi-bin/koha/opac-user.pl when not logged in you should see the same "Log in with Google" button on that page. - In each case the Google button should point to /cgi-bin/koha/svc/auth/googleopenidconnect - If you disable GoogleOpenIDConnect the buttons should disappear. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Please resubmit without the changes to opac.css Created attachment 125486 [details] [review] Bug 29006: Make GoogleOpenIDConnect options consistent in the OPAC This patch makes modifications to OPAC templates to make the Google login options more consistent. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - In the staff interface, enable the GoogleOpenIDConnect preference, and populate the GoogleOAuth2ClientID the GoogleOAuth2ClientSecret with values (they don't need to be valid). - On the OPAC main page you should see a "Log in with Google" button above the Koha login form. - If you click the "Log in to your account" link at the top of the page you should see a "Log in with Google" button in the modal window - If you navigate directly to /cgi-bin/koha/opac-user.pl when not logged in you should see the same "Log in with Google" button on that page. - In each case the Google button should point to /cgi-bin/koha/svc/auth/googleopenidconnect - If you disable GoogleOpenIDConnect the buttons should disappear. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> (In reply to Jonathan Druart from comment #7) > Please resubmit without the changes to opac.css Whoops, sorry about that! Pushed to master for 21.11, thanks to everybody involved! |