Bug 2943

Summary: Search-results give incorrect 'availability' from missing 'maxItemsinSearchResults' syspref
Product: Koha Reporter: Chris Cormack <chris>
Component: SearchingAssignee: Galen Charlton <gmcharlt>
Status: CLOSED FIXED QA Contact:
Severity: major    
Priority: PATCH-Sent (DO NOT USE) CC: fridolin.somers, m.de.rooy, mtj
Version: rel_3_0   
Hardware: PC   
OS: All   
See Also: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2142
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: patch
.
search results without 'maxItemsinSearchResults' syspref
better search results *with* 'maxItemsinSearchResults' syspref

Description Chris Cormack 2010-05-21 01:04:35 UTC


---- Reported by mason@kohaaloha.com 2009-02-04 02:00:33 ----

'maxItemsinSearchResults' syspref does not exist for MARC21 install

means bib-search always returns 1 item only.

http://git.koha.org/cgi-bin/gitweb.cgi?p=Koha;a=blob;f=C4/Search.pm;h=1509f4909988498bf92b3784320b07c11539fe0f;hb=d95f1d6dc0cfe62bc417a4ad1e83a52aeab468c8#l1488


mason@fugu:~/git/3.0.x$ grep -r maxItemsInSearchResults ./*
./installer/data/mysql/updatedatabase.pl:$dbh->do("INSERT INTO `systempreferences` (variable,value,explanation,options,type) VALUES('maxItemsInSearchResults',20,'Specify the maximum number of items to display for each result on a page of results',NULL,'free')");

./installer/data/mysql/fr-FR/1-Obligatoire/unimarc_standard_systemprefs.sql:INSERT INTO `systempreferences` (variable,value,explanation,options,type) VALUES('maxItemsInSearchResults',20,'Spécifie le nombre maximum d''exemplaires à afficher sur les pages de résultats',NULL,'free');



---- Additional Comments From mason@kohaaloha.com 2009-02-04 02:11:49 ----

Created an attachment
patch





---- Additional Comments From mason@kohaaloha.com 2009-02-04 14:32:30 ----

as atz noticed...

this syspref should correctly be an 'int', not a 'free' type



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:04 UTC  ---

This bug was previously known as _bug_ 2943 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=2943
Imported an attachment (id=982)

Actual time not defined. Setting to 0.0
The original reporter of this bug does not have
   an account here. Reassigning to the person who moved
   it here: chris@bigballofwax.co.nz.
   Previous reporter was mason@kohaaloha.com.
The original submitter of attachment 982 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.

Comment 1 Mason James 2010-07-27 12:37:19 UTC
Created attachment 2430 [details]
.
Comment 2 Mason James 2010-07-27 12:50:51 UTC
Created attachment 2431 [details]
search results without 'maxItemsinSearchResults' syspref
Comment 3 Mason James 2010-07-27 12:51:34 UTC
Created attachment 2432 [details]
better search results *with* 'maxItemsinSearchResults' syspref
Comment 4 Marcel de Rooy 2011-01-31 08:50:04 UTC
error: patch failed: installer/data/mysql/en/mandatory/sysprefs.sql:55
error: installer/data/mysql/en/mandatory/sysprefs.sql: patch does not apply

Changing patch status.
Comment 5 Chris Cormack 2011-07-07 21:08:44 UTC
Fixed by 2142