Summary: | Reports result menu shows too many dividers | ||
---|---|---|---|
Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
Component: | Reports | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | andrewfh, david, jonathan.druart, nugged, oleonard |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5697 | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This removes borders between sections that are not required. The SQL report batch operations dropdown menu has divider list items which add a border between sections (bibliographic records, item records, etc.). This element is redundant because the sections have "headers" which also add a border.
|
Version(s) released in: |
22.05.00
|
Bug Depends on: | 29186 | ||
Bug Blocks: | |||
Attachments: |
Screenshot of the bug
Bug 29679: Remove redundant divider element from reports menu Bug 29679: Remove redundant divider element from reports menu Bug 29679: Remove redundant divider element from reports menu |
Description
Fridolin Somers
2021-12-10 20:24:45 UTC
Created attachment 128408 [details]
Screenshot of the bug
Test with report from Bug 5697 : SELECT biblio.biblionumber , biblio.title, items.itemnumber, items.itemcallnumber, items.barcode, borrowers.firstname, borrowers.surname, borrowers.borrowernumber, borrowers.cardnumber FROM issues LEFT JOIN borrowers ON borrowers.borrowernumber=issues.borrowernumber LEFT JOIN items ON issues.itemnumber=items.itemnumber LEFT JOIN biblio ON items.biblionumber=biblio.biblionumber ORDER BY RAND() Owen, should we remove the .dropdown-header's border-top? Created attachment 128456 [details] [review] Bug 29679: Remove redundant divider element from reports menu The SQL report batch operations dropdown menu has divider list items which add a border between sections (Bibliographic records, item records, etc.). This element is redundant because the sections have "headers" which also add a border. This patch removes them. To test, apply the patch and run an SQL report which will return results that trigger the batch modification menu: SELECT biblio.biblionumber , biblio.title, items.itemnumber, items.itemcallnumber, items.barcode, borrowers.firstname, borrowers.surname, borrowers.borrowernumber, borrowers.cardnumber FROM issues LEFT JOIN borrowers ON borrowers.borrowernumber=issues.borrowernumber LEFT JOIN items ON issues.itemnumber=items.itemnumber LEFT JOIN biblio ON items.biblionumber=biblio.biblionumber ORDER BY RAND() There should be no double border in the menu. Created attachment 128479 [details] [review] Bug 29679: Remove redundant divider element from reports menu The SQL report batch operations dropdown menu has divider list items which add a border between sections (Bibliographic records, item records, etc.). This element is redundant because the sections have "headers" which also add a border. This patch removes them. To test, apply the patch and run an SQL report which will return results that trigger the batch modification menu: SELECT biblio.biblionumber , biblio.title, items.itemnumber, items.itemcallnumber, items.barcode, borrowers.firstname, borrowers.surname, borrowers.borrowernumber, borrowers.cardnumber FROM issues LEFT JOIN borrowers ON borrowers.borrowernumber=issues.borrowernumber LEFT JOIN items ON issues.itemnumber=items.itemnumber LEFT JOIN biblio ON items.biblionumber=biblio.biblionumber ORDER BY RAND() There should be no double border in the menu. Signed-off-by: David Nind <david@davidnind.com> Created attachment 128568 [details] [review] Bug 29679: Remove redundant divider element from reports menu The SQL report batch operations dropdown menu has divider list items which add a border between sections (Bibliographic records, item records, etc.). This element is redundant because the sections have "headers" which also add a border. This patch removes them. To test, apply the patch and run an SQL report which will return results that trigger the batch modification menu: SELECT biblio.biblionumber , biblio.title, items.itemnumber, items.itemcallnumber, items.barcode, borrowers.firstname, borrowers.surname, borrowers.borrowernumber, borrowers.cardnumber FROM issues LEFT JOIN borrowers ON borrowers.borrowernumber=issues.borrowernumber LEFT JOIN items ON issues.itemnumber=items.itemnumber LEFT JOIN biblio ON items.biblionumber=biblio.biblionumber ORDER BY RAND() There should be no double border in the menu. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (In reply to Jonathan Druart from comment #3) > Owen, should we remove the .dropdown-header's border-top? I think it makes more sense to keep this CSS and remove divider HTML element Pushed to master for 22.05, thanks to everybody involved 🦄 Missing dependency, not backported to 21.05. Please ask if needed. |