Summary: | skeleton.pl missing semicolon | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi <tomascohen> |
Component: | Installation and upgrade (command-line installer) | Assignee: | Tomás Cohen Arazi <tomascohen> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | andrewfh, fridolin.somers, jonathan.druart, kyle |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.05.00,21.11.02
|
|
Attachments: |
Bug 29813: Add missing semicolon in skeleton.pl
Bug 29813: Add missing semicolon in skeleton.pl Bug 29813: Add missing semicolon in skeleton.pl |
Description
Tomás Cohen Arazi
2022-01-06 18:27:34 UTC
Created attachment 129115 [details] [review] Bug 29813: Add missing semicolon in skeleton.pl This has no effect as it is not causing problems. But. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 129129 [details] [review] Bug 29813: Add missing semicolon in skeleton.pl This has no effect as it is not causing problems. But. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> (In reply to Tomás Cohen Arazi from comment #1) > This has no effect as it is not causing problems. But. But? It's not needed if it's the last statement of the block. Created attachment 129191 [details] [review] Bug 29813: Add missing semicolon in skeleton.pl This has no effect as it is not causing problems. But. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> It's not a bug IMO, but don't want to argue more than 5 seconds here :D I impacted wiki page https://wiki.koha-community.org/wiki/Database_updates#How_to_write_an_atomicupdate_file Pushed to master for 22.05, thanks to everybody involved 🦄 Pushed to 21.11.x for 21.11.02 Not backporting to 21.05, please ask if needed. |