Bug 29935

Summary: Add option to search in archived suggestions to all search tabs
Product: Koha Reporter: Iadis <dnlhlse>
Component: AcquisitionsAssignee: Frédéric Demians <f.demians>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: caroline.cyr-la-rose, david, f.demians, matt.blenkinsop, tomascohen
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Caroline Cyr La Rose Documentation submission: https://gitlab.com/koha-community/koha-manual/-/merge_requests/681
Text to go in the release notes:
This adds a checkbox 'Include archived' to all of the search filter tabs for suggestions in the staff interface.
Version(s) released in:
23.05.00
Attachments: Example of archive tick box and potential addition
Extracted screenshot 1
Extracted screenshot 2
Bug 29935: Archived suggestions filter always visible
Bug 29935: Archived suggestions filter always visible
Bug 29935: Archived suggestions filter always visible

Description Iadis 2022-01-25 00:50:59 UTC
Created attachment 129741 [details]
Example of archive tick box and potential addition

In Acquisitions > Suggestions management there is the "Filter by" column on the left side of the page. 

Bibliographic Information
Suggestion Information
Acquisition Information

Suggestion Information gives an option to tick to " Include Archived: " but does not have this option for Bibliographic Information. 
To search archived using Bibliographic Information you must open the Suggestion Information column, tick "Include Archived" and close or finish your search from Bibliographic Information. 


It would a good quality of life feature to have "Include Archive" also available under Bibliographic Information or located outside the search boxes so that you do not need to needlessly open all the columns to search anyway.

If this is not possible perhaps having results include archived by default to prevent button cluster. 

Just an idea, thank you for considering.
Comment 1 Owen Leonard 2022-01-25 11:24:42 UTC
Created attachment 129744 [details]
Extracted screenshot 1

Pulling two images out of the Word document for easier access
Comment 2 Owen Leonard 2022-01-25 11:25:09 UTC
Created attachment 129745 [details]
Extracted screenshot 2
Comment 3 Frédéric Demians 2022-12-24 09:57:45 UTC
Created attachment 144834 [details] [review]
Bug 29935: Archived suggestions filter always visible

In suggestion sidebar menu, make visible 'Include archived' checkbox
without having to develop a filter.
Comment 4 David Nind 2023-01-29 17:28:08 UTC
Created attachment 145794 [details] [review]
Bug 29935: Archived suggestions filter always visible

In suggestion sidebar menu, make visible 'Include archived' checkbox
without having to develop a filter.

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 David Nind 2023-01-29 17:36:16 UTC
Testing notes (using koha-testing-docker):

1. Apply the patch.
2. Add some suggestions using the staff interface.
3. Archive one suggestion (Actions column (not labelled) > Archive).
4. Note that "Include archived" is now listed after the filters on the left sidebar.
5. Test that listing archived suggestions works for both the bibliographic and suggestion information filters:
   . Enter the title of the archived suggestion in Bibliographic information > Title
   . Select "Included archived"
   . The archived suggestion should show in the list
   . Repeat with "Included archived" not selected
   . Archived suggestion should not show in the list
Comment 6 David Nind 2023-01-29 17:39:09 UTC
I've changed the assignee to Frédéric - please update if this in not correct.
Comment 7 Jonathan Druart 2023-02-23 09:16:00 UTC
Created attachment 147200 [details] [review]
Bug 29935: Archived suggestions filter always visible

In suggestion sidebar menu, make visible 'Include archived' checkbox
without having to develop a filter.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 8 Tomás Cohen Arazi 2023-03-10 14:14:42 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 9 Matt Blenkinsop 2023-03-10 16:47:21 UTC
Enhancement - not backporting to 22.11.x
Nice work everyone!