Bug 30543

Summary: Decouple DumpSearchQueryTemplate from other template dump preferences
Product: Koha Reporter: Nick Clemens <nick>
Component: Architecture, internals, and plumbingAssignee: Nick Clemens <nick>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: andrewfh, lucas
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00
Bug Depends on: 24103    
Bug Blocks:    
Attachments: Bug 30543: Decouple DumpSearchQueryTemplate from other tempalte dump preferences
Bug 30543: Decouple DumpSearchQueryTemplate from other tempalte dump preferences
Bug 30543: Decouple DumpSearchQueryTemplate from other tempalte dump preferences

Description Nick Clemens 2022-04-14 13:18:24 UTC
When using dump search query to debug search issues it would be simpler if we could get only the search query
Comment 1 Nick Clemens 2022-04-14 13:20:19 UTC
Created attachment 133310 [details] [review]
Bug 30543: Decouple DumpSearchQueryTemplate from other tempalte dump preferences

To test:
1 - Enable DumpSearchQueryTemplate
2 - Confirm you can find the search query in the HTML as a comment
3 - Enable other template dump preference
4 - Confirm they work as before
5 - Confirm new description of preference makes sense
Comment 2 ByWater Sandboxes 2022-08-01 17:57:31 UTC
Created attachment 138485 [details] [review]
Bug 30543: Decouple DumpSearchQueryTemplate from other tempalte dump preferences

To test:
1 - Enable DumpSearchQueryTemplate
2 - Confirm you can find the search query in the HTML as a comment
3 - Enable other template dump preference
4 - Confirm they work as before
5 - Confirm new description of preference makes sense

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 3 Katrin Fischer 2022-08-08 19:40:37 UTC
Created attachment 138853 [details] [review]
Bug 30543: Decouple DumpSearchQueryTemplate from other tempalte dump preferences

To test:
1 - Enable DumpSearchQueryTemplate
2 - Confirm you can find the search query in the HTML as a comment
3 - Enable other template dump preference
4 - Confirm they work as before
5 - Confirm new description of preference makes sense

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2022-08-09 11:46:38 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 5 Lucas Gass 2022-09-30 22:38:58 UTC
Enhancement will not be backported to 22.05.x series unless requested