Summary: | 'Insert' button in notices editor not adding selected placeholders to notice | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Tools | Assignee: | Bugs List <koha-bugs> |
Status: | CLOSED FIXED | QA Contact: | Martin Renvoize <martin.renvoize> |
Severity: | normal | ||
Priority: | P5 - low | CC: | martin.renvoize, oleonard |
Version: | Main | Keywords: | regression |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.05.00
|
|
Bug Depends on: | 29155 | ||
Bug Blocks: | |||
Attachments: |
Bug 30709: 'Insert' button in notices editor not adding selected placeholders to notice
Bug 30709: 'Insert' button in notices editor not adding selected placeholders to notice |
Description
Katrin Fischer
2022-05-06 09:21:16 UTC
Pretty sure this comes from bug 30545. What I've discovered so far is that we add `content_` to the textarea id and appear to drop the 'name' for the input.. but it needs a bit more digging.. Any chance you can take a look Owen? Created attachment 134727 [details] [review] Bug 30709: 'Insert' button in notices editor not adding selected placeholders to notice This patch updates letter.js so that it uses .prop("selected") to look for selected <option>s instead of .attr("selected"). This is necessary because of the jQuery upgrade. To test, apply the patch and edit any notice. Test that you can select one or more database columns and insert them into the body of a notice by clicking "Insert." Confirm that your selections are inserted where you left the cursor in the message textarea. Test with multiple message transports and with multiple languages installed (with TranslateNotices enabled). Created attachment 134728 [details] [review] Bug 30709: 'Insert' button in notices editor not adding selected placeholders to notice This patch updates letter.js so that it uses .prop("selected") to look for selected <option>s instead of .attr("selected"). This is necessary because of the jQuery upgrade. To test, apply the patch and edit any notice. Test that you can select one or more database columns and insert them into the body of a notice by clicking "Insert." Confirm that your selections are inserted where you left the cursor in the message textarea. Test with multiple message transports and with multiple languages installed (with TranslateNotices enabled). Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Trivial fix, thanks Owen. Straight PQA as it's all working now :) Pushed to master for 22.05, thanks to everybody involved 🦄 |