Bug 30930

Summary: Ability to change authority type while editing record
Product: Koha Reporter: Aleisha Amohia <aleisha>
Component: CatalogingAssignee: Aleisha Amohia <aleisha>
Status: Needs documenting --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: a.roussos, david, jacob.omara, m.de.rooy, philip.orr
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: Sponsored Patch complexity: Small patch
Documentation contact: Philip Orr Documentation submission: https://gitlab.com/koha-community/koha-manual/-/merge_requests/869
Text to go in the release notes:
This adds the ability to change the MARC authority type/framework used while editing an authority record.
Version(s) released in:
23.05.00
Attachments: Bug 30930: Ability to change auth type while editing record
Bug 30930: Ability to change auth type while editing record
Bug 30930: Ability to change auth type while editing record
Bug 30930: Ability to change auth type while editing record
Bug 30930: (QA follow-up) Tidy code block

Description Aleisha Amohia 2022-06-08 23:42:37 UTC
When editing a biblio record, the editor has a 'Settings' menu which allows you to change the record's framework within the editor.

The authority editor should have this feature too.
Comment 1 Aleisha Amohia 2022-06-09 00:58:28 UTC
Created attachment 135851 [details] [review]
Bug 30930: Ability to change auth type while editing record

This patch adds the ability to change the authority MARC framework/type
being used while editing an authority record.

To test:

1) Log into the staff client and go to Authorities
2) Search for an existing authority and edit it
3) Notice there is no way to change this authority type
4) Apply patch, restart services, refresh editor in browser
5) Notice the new Settings dropdown. Click to open
6) Confirm the correct current authority type is selected
7) Select another type to change to that. The page should reload
8) Confirm the page reloads with the correct authority type framework
loaded and the MARC data is still correct

Sponsored-by: Education Services Australia SCIS
Comment 2 David Nind 2022-07-09 22:36:10 UTC
Patch no longer applies 8-(..

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 30930: Ability to change auth type while editing record
Using index info to reconstruct a base tree...
M	authorities/authorities.pl
Falling back to patching base and 3-way merge...
Auto-merging authorities/authorities.pl
CONFLICT (content): Merge conflict in authorities/authorities.pl
error: Failed to merge in the changes.
Patch failed at 0001 Bug 30930: Ability to change auth type while editing record
Comment 3 Aleisha Amohia 2023-02-12 22:17:53 UTC
Created attachment 146555 [details] [review]
Bug 30930: Ability to change auth type while editing record

This patch adds the ability to change the authority MARC framework/type
being used while editing an authority record.

To test:

1) Log into the staff client and go to Authorities
2) Search for an existing authority and edit it
3) Notice there is no way to change this authority type
4) Apply patch, restart services, refresh editor in browser
5) Notice the new Settings dropdown. Click to open
6) Confirm the correct current authority type is selected
7) Select another type to change to that. The page should reload
8) Confirm the page reloads with the correct authority type framework
loaded and the MARC data is still correct

Sponsored-by: Education Services Australia SCIS
Comment 4 Jacob O'Mara 2023-02-20 15:56:30 UTC
Created attachment 146969 [details] [review]
Bug 30930: Ability to change auth type while editing record

This patch adds the ability to change the authority MARC framework/type
being used while editing an authority record.

To test:

1) Log into the staff client and go to Authorities
2) Search for an existing authority and edit it
3) Notice there is no way to change this authority type
4) Apply patch, restart services, refresh editor in browser
5) Notice the new Settings dropdown. Click to open
6) Confirm the correct current authority type is selected
7) Select another type to change to that. The page should reload
8) Confirm the page reloads with the correct authority type framework
loaded and the MARC data is still correct

Sponsored-by: Education Services Australia SCIS
Signed-off-by: Jacob O'Mara <jacob.omara@ptfs-europe.com>
Comment 5 Kyle M Hall 2023-03-24 16:19:58 UTC
Created attachment 148674 [details] [review]
Bug 30930: Ability to change auth type while editing record

This patch adds the ability to change the authority MARC framework/type
being used while editing an authority record.

To test:

1) Log into the staff client and go to Authorities
2) Search for an existing authority and edit it
3) Notice there is no way to change this authority type
4) Apply patch, restart services, refresh editor in browser
5) Notice the new Settings dropdown. Click to open
6) Confirm the correct current authority type is selected
7) Select another type to change to that. The page should reload
8) Confirm the page reloads with the correct authority type framework
loaded and the MARC data is still correct

Sponsored-by: Education Services Australia SCIS
Signed-off-by: Jacob O'Mara <jacob.omara@ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 6 Kyle M Hall 2023-03-24 16:21:03 UTC
Created attachment 148675 [details] [review]
Bug 30930: (QA follow-up) Tidy code block

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 7 Tomás Cohen Arazi 2023-04-06 13:03:59 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 8 Jacob O'Mara 2023-04-17 07:20:48 UTC
Enhancement - not backporting to 22.11.x

Nice work everyone!