Bug 30963

Summary: Automatically refresh the curbside pickups list
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: CirculationAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Kyle M Hall <kyle>
Severity: enhancement    
Priority: P5 - low CC: alissa.desaintlaurent, black23, caroline.cyr-la-rose, gmcharlt, jacob.omara, katrin.fischer, kyle.m.hall, kyle, sonia.bouis
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: Sponsored Patch complexity: ---
Documentation contact: Caroline Cyr La Rose Documentation submission: https://gitlab.com/koha-community/koha-manual/-/merge_requests/618
Text to go in the release notes:
Version(s) released in:
23.05.00
Bug Depends on: 30650    
Bug Blocks:    
Attachments: Bug 30963: Automatically refresh the curbside pickups list
Bug 30963: Automatically refresh the curbside pickups list
Bug 30963: Automatically refresh the curbside pickups list

Description Jonathan Druart 2022-06-15 08:19:26 UTC
Librarians would like the page to be automatically refreshed every 5 minutes.

I am wondering if we need:
* a syspref
* hardcode 5 minutes (certainly not)
* provide JS to include in IntranetUserJS, but don't provide the feature out of the box
Comment 1 Jonathan Druart 2022-07-31 07:50:48 UTC
Katrin, what's your opinion on this one?
Comment 2 Katrin Fischer 2022-08-01 07:22:52 UTC
Maybe providing JS if possible is a good idea to get more feedback - I am not sure actually if it would be a good feature or not. I an ideal setting we should probably trigger a refresh when another pickup was scheduled.
Comment 3 Jonathan Druart 2022-11-04 15:38:25 UTC
Created attachment 143237 [details] [review]
Bug 30963: Automatically refresh the curbside pickups list

Librarians would like the page to be automatically refreshed every X minutes.

This patch is suggesting to have a checkbox at the top of the page to
let the user refresh the page given the delay they want.

We could later improve this by setting this value in a localStorage
variable.

Test plan:
Go to the curbside pickup page
Notice the new checkbox at the top
Notice that the "Refresh" button has been moved at the top as well
Play with the checkbox and the input, and confirm that the behaviour is
consistent

Sponsored-by: Association KohaLa - https://koha-fr.org/
Comment 4 Jonathan Druart 2022-11-04 15:40:26 UTC
I went with the nice version, I think (not the ideal one however).

Note that I won't have much additional time for this.

https://snipboard.io/sfo6We.jpg
Comment 5 David Nind 2022-11-04 22:55:16 UTC
Created attachment 143295 [details] [review]
Bug 30963: Automatically refresh the curbside pickups list

Librarians would like the page to be automatically refreshed every X minutes.

This patch is suggesting to have a checkbox at the top of the page to
let the user refresh the page given the delay they want.

We could later improve this by setting this value in a localStorage
variable.

Test plan:
Go to the curbside pickup page
Notice the new checkbox at the top
Notice that the "Refresh" button has been moved at the top as well
Play with the checkbox and the input, and confirm that the behaviour is
consistent

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: David Nind <david@davidnind.com>
Comment 6 Kyle M Hall 2022-11-18 16:33:00 UTC
Created attachment 144073 [details] [review]
Bug 30963: Automatically refresh the curbside pickups list

Librarians would like the page to be automatically refreshed every X minutes.

This patch is suggesting to have a checkbox at the top of the page to
let the user refresh the page given the delay they want.

We could later improve this by setting this value in a localStorage
variable.

Test plan:
Go to the curbside pickup page
Notice the new checkbox at the top
Notice that the "Refresh" button has been moved at the top as well
Play with the checkbox and the input, and confirm that the behaviour is
consistent

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 7 Tomás Cohen Arazi 2022-12-01 13:04:33 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 8 Jacob O'Mara 2022-12-05 12:17:53 UTC
ENHANCEMENT: Won't be back-ported to 22.11.x
Apologies!