Bug 31129

Summary: Number of restrictions is always "0" on the "Check out" tab
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: CirculationAssignee: Martin Renvoize <martin.renvoize>
Status: CLOSED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: normal    
Priority: P5 - low CC: arthur.suzuki, gmcharlt, kyle.m.hall, lucas, martin.renvoize, victor
Version: unspecifiedKeywords: Academy
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00, 22.05.05, 21.11.12
Bug Depends on:    
Bug Blocks: 23681    
Attachments: Bug 31129: Fix debarment count on circulation page

Description Jonathan Druart 2022-07-11 12:51:09 UTC
circ/circulation.tt vs members/moremember.tt:


circ/circulation.tt:                            <a id="debarments-tab-link" href="#reldebarments">Restrictions ([% debarments.count || 0 | html %])</a>

members/moremember.tt:                                <a id="debarments-tab-link" href="#reldebarments">Restrictions ([% debarments.size || 0 | html %])</a>
Comment 1 Katrin Fischer 2022-07-11 14:18:48 UTC
There is a fix for this in the patch set for user defined restristions: bug 23681
Comment 2 Martin Renvoize 2022-07-12 06:51:13 UTC
The last two follow-ups on the above bug fix bugs in restrictions.. happy to split them out into this bug and another if we want to have them easily backportable.  I think they can retain PQA though.. they're small and self contained and well tested as part of the above bug.
Comment 3 Martin Renvoize 2022-07-12 06:59:56 UTC
Created attachment 137602 [details] [review]
Bug 31129: Fix debarment count on circulation page

This patch was split from bug 23681 where QA identified the issue.

This patch fixes the debarment count displayed on the circulation page
tabs

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 4 Martin Renvoize 2022-07-12 07:01:48 UTC
Patch split from bug 23681 as promised above.. QA pulled through.  This should make it very trivial to backport.
Comment 5 Tomás Cohen Arazi 2022-07-18 13:31:39 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 6 Lucas Gass 2022-08-23 16:09:43 UTC
Backported to 22.05.x for 22.05.05
Comment 7 Arthur Suzuki 2022-08-30 09:19:27 UTC
thx pushed to 21.11.x for 21.11.12
Comment 8 Victor Grousset/tuxayo 2022-09-09 23:51:16 UTC
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document, marking resolved.