Bug 31153

Summary: Search bar not visible on recalls history page
Product: Koha Reporter: Caroline Cyr La Rose <caroline.cyr-la-rose>
Component: PatronsAssignee: Lucas Gass <lucas>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: arthur.suzuki, gmcharlt, kyle.m.hall, lucas, martin.renvoize
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00, 22.05.05
Bug Depends on:    
Bug Blocks: 29734    
Attachments: Holds history page for comparison
Recalls history page
Bug 31153: Correct include for patron-search-header
Bug 31153: Correct include for patron-search-header
Bug 31146: Fix unclosed table element
Bug 31153: Correct include for patron-search-header

Description Caroline Cyr La Rose 2022-07-13 21:47:42 UTC
When accessing the 'Recalls history' tab in a patron's file in the staff interface, the section where the Koha logo and search bar are disappears.

To test:
1) Turn on recalls
   1.1) In Administration > Global system preferences, enable UseRecalls
   1.2) Add recalls permissions in your circulation rules
2) In the OPAC, log in as a patron
3) Find a record with checked out items and place a recall
4) In the staff interface, go to the patron's account
5) Click on any tab on the left in the patron's account (e.g. Holds history)
--> Note that the Koha logo and search bar is at the top of the page between the module menu and the breadcrumbs
6) Click on the 'Recalls history' tab
--> Note that the Koha logo and search bar disappear
Comment 1 Caroline Cyr La Rose 2022-07-13 21:49:36 UTC
Created attachment 137688 [details]
Holds history page for comparison

This is the holds history page, for comparison. Note that the logo and search bar are visible
Comment 2 Caroline Cyr La Rose 2022-07-13 21:50:31 UTC
Created attachment 137689 [details]
Recalls history page

The is the Recalls history page. Note that the logo and search bar are not visible
Comment 3 Lucas Gass 2022-07-14 15:12:23 UTC
Created attachment 137729 [details] [review]
Bug 31153: Correct include for patron-search-header

To test:
1) Turn on recalls
   1.1) In Administration > Global system preferences, enable UseRecalls
   1.2) Add recalls permissions in your circulation rules
2) In the OPAC, log in as a patron
3) Find a record with checked out items and place a recall
4) In the staff interface, go to the patron's account
5) Click on any tab on the left in the patron's account (e.g. Holds history)
--> Note that the Koha logo and search bar is at the top of the page between the module menu and the breadcrumbs
6) Click on the 'Recalls history' tab
--> Note that the Koha logo and search bar disappear
7) Apply patch
8) Conform search bar is there
Comment 4 Caroline Cyr La Rose 2022-07-14 15:21:14 UTC
Created attachment 137730 [details] [review]
Bug 31153: Correct include for patron-search-header

To test:
1) Turn on recalls
   1.1) In Administration > Global system preferences, enable UseRecalls
   1.2) Add recalls permissions in your circulation rules
2) In the OPAC, log in as a patron
3) Find a record with checked out items and place a recall
4) In the staff interface, go to the patron's account
5) Click on any tab on the left in the patron's account (e.g. Holds history)
--> Note that the Koha logo and search bar is at the top of the page between the module menu and the breadcrumbs
6) Click on the 'Recalls history' tab
--> Note that the Koha logo and search bar disappear
7) Apply patch
8) Conform search bar is there

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Comment 5 Caroline Cyr La Rose 2022-07-14 15:24:38 UTC
Thanks Lucas!

I still had my Recalls history page open from yesterday, so I only had to apply the patch and refresh the page :) It works perfectly!
Comment 6 Lucas Gass 2022-07-14 15:31:44 UTC
Created attachment 137731 [details] [review]
Bug 31146: Fix unclosed table element

To test:
1) Install another language and enable it in the OPACLanguages system preference
2) Also make sure opaclanguagesdisplay is set to Allow
3) Make sure OpacLangSelectorMode is set to display the switch in the footer (either top and bottom or footer only)
4) Turn on recalls
   4.1) In Administration > Global system preferences, enable UseRecalls
   4.2) Add recalls permissions in your circulation rules
5) In the OPAC, log in as a patron
6) Find a record with checked out items and place a recall
7) Go to your account
--> Note that the language switch is at the bottom left of the screen
8) Click on any tab in the patron's account
--> Note that the language switch is at the bottom left of the screen
9) Click on 'Your recalls history'
--> Note that the language switch is right under the recalls history table
10) Apply patch
11) The changelanguage div should now be properly placed at the bottom of the page.
Comment 7 Lucas Gass 2022-07-14 15:36:05 UTC
Sorry, attached a patch to the wrong bug.
Comment 8 Martin Renvoize 2022-07-15 14:38:25 UTC
Created attachment 137765 [details] [review]
Bug 31153: Correct include for patron-search-header

To test:
1) Turn on recalls
   1.1) In Administration > Global system preferences, enable UseRecalls
   1.2) Add recalls permissions in your circulation rules
2) In the OPAC, log in as a patron
3) Find a record with checked out items and place a recall
4) In the staff interface, go to the patron's account
5) Click on any tab on the left in the patron's account (e.g. Holds history)
--> Note that the Koha logo and search bar is at the top of the page between the module menu and the breadcrumbs
6) Click on the 'Recalls history' tab
--> Note that the Koha logo and search bar disappear
7) Apply patch
8) Conform search bar is there

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 9 Martin Renvoize 2022-07-15 14:38:46 UTC
Trivial code change, solid fix.

Passing QA
Comment 10 Tomás Cohen Arazi 2022-07-18 14:53:55 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 11 Lucas Gass 2022-08-23 17:34:21 UTC
Backported to 22.05.x for 22.05.05
Comment 12 Arthur Suzuki 2022-08-26 12:14:34 UTC
Recalls feature not present in 21.11. won't backport.