Bug 31305

Summary: Useless "type" parameter passed in detail.tt
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Architecture, internals, and plumbingAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: nick
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00
Attachments: Bug 31305: Remove type= from detail.pl
Bug 31305: Remove type= from detail.pl

Description Jonathan Druart 2022-08-08 14:00:38 UTC
<td><a href="/cgi-bin/koha/catalogue/moredetail.pl?type=[% item.type | uri %]

This 'type' parameter is never used.
Comment 1 Jonathan Druart 2022-08-08 14:01:38 UTC
Created attachment 138805 [details] [review]
Bug 31305: Remove type= from detail.pl

This is not related to anything known.. was it "itype" at some point?
`git log -p` will tell you that it's there for a looong time already
Comment 2 Nick Clemens 2022-08-08 14:34:50 UTC
Created attachment 138815 [details] [review]
Bug 31305: Remove type= from detail.pl

This is not related to anything known.. was it "itype" at some point?
`git log -p` will tell you that it's there for a looong time already

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 3 Nick Clemens 2022-08-08 14:35:14 UTC
Trivial, checked script, templates, and includes - no sign of use
Comment 4 Tomás Cohen Arazi 2022-08-08 16:21:30 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!