Bug 31316

Summary: Remove GetItemsInfo from opac-sendbasket
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Architecture, internals, and plumbingAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Nick Clemens (kidclamp) <nick>
Severity: enhancement    
Priority: P5 - low CC: lucas, nick
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00
Bug Depends on: 31306    
Bug Blocks: 27272    
Attachments: Bug 31316: Remove GetItemsInfo from opac-sendbasket
Bug 31316: Remove GetItemsInfo from opac-sendbasket
Bug 31316: Remove GetItemsInfo from opac-sendbasket
Bug 31316: Remove GetItemsInfo from opac-sendbasket
Bug 31316: (QA follow-up) Remove stray template close tag

Description Jonathan Druart 2022-08-08 14:22:59 UTC
Bug 27272 is going to remove C4::Items::GetItemsInfo in favour of Koha::Items->search_ordered.

Here we are going to deal with opac-sendbasket
Comment 1 Jonathan Druart 2022-08-08 14:51:47 UTC
Created attachment 138826 [details] [review]
Bug 31316: Remove GetItemsInfo from opac-sendbasket

Bug 27272 is going to remove C4::Items::GetItemsInfo in favour of Koha::Items->search.

Here we are going to deal with opac-sendbasket

Test plan:
List items on the modified view and confirm that all the info is
displayed correctly
Comment 2 Jonathan Druart 2022-08-08 15:05:25 UTC
Created attachment 138833 [details] [review]
Bug 31316: Remove GetItemsInfo from opac-sendbasket

Bug 27272 is going to remove C4::Items::GetItemsInfo in favour of Koha::Items->search.

Here we are going to deal with opac-sendbasket

Test plan:
List items on the modified view and confirm that all the info is
displayed correctly
Comment 3 Owen Leonard 2022-08-09 11:25:18 UTC
Created attachment 138898 [details] [review]
Bug 31316: Remove GetItemsInfo from opac-sendbasket

Bug 27272 is going to remove C4::Items::GetItemsInfo in favour of Koha::Items->search.

Here we are going to deal with opac-sendbasket

Test plan:
List items on the modified view and confirm that all the info is
displayed correctly

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 4 Nick Clemens (kidclamp) 2022-08-09 12:46:27 UTC
Created attachment 138903 [details] [review]
Bug 31316: Remove GetItemsInfo from opac-sendbasket

Bug 27272 is going to remove C4::Items::GetItemsInfo in favour of Koha::Items->search.

Here we are going to deal with opac-sendbasket

Test plan:
List items on the modified view and confirm that all the info is
displayed correctly

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 5 Nick Clemens (kidclamp) 2022-08-09 12:46:30 UTC
Created attachment 138904 [details] [review]
Bug 31316: (QA follow-up) Remove stray template close tag

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 6 Nick Clemens (kidclamp) 2022-08-09 12:47:16 UTC
This actually improves the cart/basket - before these patches location was not translated from AV, now it is - I think this is correct
Comment 7 Tomás Cohen Arazi 2022-08-09 15:06:19 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!