Bug 31577

Summary: Use patron category multi-select for OpacHiddenItemsExceptions system preference
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: System AdministrationAssignee: Katrin Fischer <katrin.fischer>
Status: CLOSED FIXED QA Contact: Kyle M Hall <kyle>
Severity: enhancement    
Priority: P5 - low CC: caroline.cyr-la-rose, gmcharlt, kyle, lucas
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Caroline Cyr La Rose Documentation submission: https://gitlab.com/koha-community/koha-manual/-/merge_requests/667
Text to go in the release notes:
Version(s) released in:
22.11.00
Attachments: Bug 31577: Use patron category multi-select for OpacHiddenItemsExceptions system preference
Bug 31577: Use patron category multi-select for OpacHiddenItemsExceptions system preference
Bug 31577: Use patron category multi-select for OpacHiddenItemsExceptions system preference
Bug 31577: Use patron category multi-select for OpacHiddenItemsExceptions system preference

Description Katrin Fischer 2022-09-16 15:57:41 UTC
The OpacHiddenItemsExceptions should be a multi-select system preference instead of asking you to write patron category codes into the input field.
Comment 1 Katrin Fischer 2022-09-19 21:33:31 UTC
Created attachment 140761 [details] [review]
Bug 31577: Use patron category multi-select for OpacHiddenItemsExceptions system preference

We are now using the patron category selects on almost all system
preferences, but OpacHiddenItemsExceptions was still missing.

To test:
- Before applying the patch:
- Add patron categories to OpacHiddenItemsExceptions using |
- Add configuration to OpacHiddenItems
- Verify all works as expected in the OPAC
- Apply patch, run database update
- Verify the system preference shows the correct settings from before
- Verify feature still works as expected
Comment 2 Katrin Fischer 2022-09-19 21:36:10 UTC
Created attachment 140762 [details] [review]
Bug 31577: Use patron category multi-select for OpacHiddenItemsExceptions system preference

We are now using the patron category selects on almost all system
preferences, but OpacHiddenItemsExceptions was still missing.

To test:
- Before applying the patch:
- Add patron categories to OpacHiddenItemsExceptions using |
- Add configuration to OpacHiddenItems
- Verify all works as expected in the OPAC
- Apply patch, run database update
- Verify the system preference shows the correct settings from before
- Verify feature still works as expected
Comment 3 David Nind 2022-09-25 05:59:23 UTC
Created attachment 140972 [details] [review]
Bug 31577: Use patron category multi-select for OpacHiddenItemsExceptions system preference

We are now using the patron category selects on almost all system
preferences, but OpacHiddenItemsExceptions was still missing.

To test:
- Before applying the patch:
- Add patron categories to OpacHiddenItemsExceptions using |
- Add configuration to OpacHiddenItems
- Verify all works as expected in the OPAC
- Apply patch, run database update
- Verify the system preference shows the correct settings from before
- Verify feature still works as expected

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 Kyle M Hall 2022-10-21 11:11:57 UTC
Created attachment 142329 [details] [review]
Bug 31577: Use patron category multi-select for OpacHiddenItemsExceptions system preference

We are now using the patron category selects on almost all system
preferences, but OpacHiddenItemsExceptions was still missing.

To test:
- Before applying the patch:
- Add patron categories to OpacHiddenItemsExceptions using |
- Add configuration to OpacHiddenItems
- Verify all works as expected in the OPAC
- Apply patch, run database update
- Verify the system preference shows the correct settings from before
- Verify feature still works as expected

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 5 Tomás Cohen Arazi 2022-10-24 17:41:37 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!