Bug 31625

Summary: Reindent tools home and tools sidebar
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: trivial    
Priority: P5 - low CC: andrewfh, katrin.fischer, lucas, martin.renvoize, testopia
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00
Bug Depends on:    
Bug Blocks: 31402    
Attachments: Bug 31625: Reindent tools home and tools sidebar
Bug 31625: (follow-up) Markup comments
Bug 31625: Reindent tools home and tools sidebar
Bug 31625: (follow-up) Markup comments
Bug 31625: Reindent tools home and tools sidebar
Bug 31625: (follow-up) Markup comments

Description Owen Leonard 2022-09-26 14:53:34 UTC
I propose to reformat the tools-home template and the tools-menu include file in the staff interface so that they have consistent spacing and indentation.
Comment 1 Owen Leonard 2022-09-26 15:11:06 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2022-09-26 15:11:10 UTC
Created attachment 140991 [details] [review]
Bug 31625: (follow-up) Markup comments

This patch adds comments to the templates to highlight the markup
structure.

This patch should have no effect on the pages' appearance or
functionality.
Comment 3 ByWater Sandboxes 2022-09-26 19:00:58 UTC
Created attachment 141002 [details] [review]
Bug 31625: Reindent tools home and tools sidebar

This patch performs general template cleanup to the tools-home and
tools-menu templates: Make indentation consistent, replace tabs with
spaces, fix invalid HTML.

To test, apply the patch and go to Tools. The page should look correct,
with no visible changes from before the patch.

Go to any tools page which shows the left-hand sidebar, e.g. Patron
lists, Batch item deletion, Inventory, etc. The menu should look
correct.

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 4 ByWater Sandboxes 2022-09-26 19:01:02 UTC
Created attachment 141003 [details] [review]
Bug 31625: (follow-up) Markup comments

This patch adds comments to the templates to highlight the markup
structure.

This patch should have no effect on the pages' appearance or
functionality.

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 5 Katrin Fischer 2022-09-26 19:20:56 UTC
Hm, I wonder if this does not clash with 31162 and if we should push one or the other first?
Comment 6 Katrin Fischer 2022-10-01 19:55:04 UTC
Created attachment 141185 [details] [review]
Bug 31625: Reindent tools home and tools sidebar

This patch performs general template cleanup to the tools-home and
tools-menu templates: Make indentation consistent, replace tabs with
spaces, fix invalid HTML.

To test, apply the patch and go to Tools. The page should look correct,
with no visible changes from before the patch.

Go to any tools page which shows the left-hand sidebar, e.g. Patron
lists, Batch item deletion, Inventory, etc. The menu should look
correct.

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 7 Katrin Fischer 2022-10-01 19:55:09 UTC
Created attachment 141186 [details] [review]
Bug 31625: (follow-up) Markup comments

This patch adds comments to the templates to highlight the markup
structure.

This patch should have no effect on the pages' appearance or
functionality.

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 8 Katrin Fischer 2022-10-01 19:56:15 UTC
(In reply to Katrin Fischer from comment #5)
> Hm, I wonder if this does not clash with bug 31162 and if we should push one or
> the other first?
Comment 9 Martin Renvoize 2022-10-03 08:22:34 UTC
It'll clash, but I'll have a quick look at rebasing the other ones upon this one.. hopefully it won't be too painful.
Comment 10 Tomás Cohen Arazi 2022-10-03 15:42:31 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 11 Martin Renvoize 2022-10-03 16:29:25 UTC
Was about to say I rebased this morning so we're all good to push.. then I spotted Tomas already had.. hehe