Summary: | When placing a hold patron name is not displaying correctly | ||
---|---|---|---|
Product: | Koha | Reporter: | Lucas Gass <lucas> |
Component: | Hold requests | Assignee: | Lucas Gass <lucas> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | normal | ||
Priority: | P5 - low | CC: | david, gmcharlt |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.11.00
|
|
Bug Depends on: | 30952 | ||
Bug Blocks: | |||
Attachments: |
Screenshot of problem
Bug 31808: Set fieldset.rows li width to 100% Bug 31808: Set fieldset.rows li width to 100% Bug 31808: Set fieldset.rows li width to 100% |
I can replicate this issue on current master as well. I think in our CSS for fieldset.rows we need to explicitly set the li elements width to 100%. Created attachment 141909 [details] [review] Bug 31808: Set fieldset.rows li width to 100% To test: 1. Find an item and try placing a hold. 2. Under 'Hold details' the first list element is the patron name, it displays far to the right in an unusual location. 3. Apply patch and regenerate CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface ) 4. Try steps 1 & 2 again. 5. The name should display correctly. Created attachment 141910 [details] [review] Bug 31808: Set fieldset.rows li width to 100% To test: 1. Find an item and try placing a hold. 2. Under 'Hold details' the first list element is the patron name, it displays far to the right in an unusual location. 3. Apply patch and regenerate CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface ) 4. Try steps 1 & 2 again. 5. The name should display correctly. Signed-off-by: David Nind <david@davidnind.com> Created attachment 141912 [details] [review] Bug 31808: Set fieldset.rows li width to 100% To test: 1. Find an item and try placing a hold. 2. Under 'Hold details' the first list element is the patron name, it displays far to the right in an unusual location. 3. Apply patch and regenerate CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface ) 4. Try steps 1 & 2 again. 5. The name should display correctly. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 22.11. Nice work everyone, thanks! |
Created attachment 141908 [details] Screenshot of problem To recreate: 1. Find an item and try placing a hold. 2. Under 'Hold details' the first list element is the patron name, it displays far to the right in an unusual location. ( see attachment )