Bug 31826

Summary: Add page-section to item form on order receive page (acq)
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: gmcharlt
Version: Main   
Hardware: All   
OS: All   
URL: /cgi-bin/koha/acqui/orderreceive.pl?ordernumber=1&invoiceid=1
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00
Bug Depends on: 30952    
Bug Blocks: 31757    
Attachments: Bug 31826: Add page-section to item form on order receive page (acq)
Bug 31826: Add page-section to item form on order receive page (acq)
Bug 31826: Add page-section to item form on order receive page (acq)

Description Katrin Fischer 2022-10-16 11:25:00 UTC
When receiving an order with connected 'order items', the item table is missing the page-section and appears with grey background.
Comment 1 Owen Leonard 2022-11-09 17:17:03 UTC
Created attachment 143558 [details] [review]
Bug 31826: Add page-section to item form on order receive page (acq)

This patch adds a "page-section" class to the container div around the
items table on the order receive page in acquisitions.

To test, apply the patch and go to Acquisitions.

- Locate a vendor and few its details.
- Click "Receive shipments."
- Fill out the "Receive shipment" form if you have no existing
  shipments. Otherwise click on the invoice number link to get to the
  "Receive orders" page.
- In the table of pending orders, click a "Receive" link.
- On the "Receive items" page there should be three sections: Catalog
  details, Acquisitions details, and Items.
Comment 2 David Nind 2022-11-09 20:57:06 UTC
Created attachment 143590 [details] [review]
Bug 31826: Add page-section to item form on order receive page (acq)

This patch adds a "page-section" class to the container div around the
items table on the order receive page in acquisitions.

To test, apply the patch and go to Acquisitions.

- Locate a vendor and few its details.
- Click "Receive shipments."
- Fill out the "Receive shipment" form if you have no existing
  shipments. Otherwise click on the invoice number link to get to the
  "Receive orders" page.
- In the table of pending orders, click a "Receive" link.
- On the "Receive items" page there should be three sections: Catalog
  details, Acquisitions details, and Items.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Katrin Fischer 2022-11-09 23:33:01 UTC
Created attachment 143602 [details] [review]
Bug 31826: Add page-section to item form on order receive page (acq)

This patch adds a "page-section" class to the container div around the
items table on the order receive page in acquisitions.

To test, apply the patch and go to Acquisitions.

- Locate a vendor and few its details.
- Click "Receive shipments."
- Fill out the "Receive shipment" form if you have no existing
  shipments. Otherwise click on the invoice number link to get to the
  "Receive orders" page.
- In the table of pending orders, click a "Receive" link.
- On the "Receive items" page there should be three sections: Catalog
  details, Acquisitions details, and Items.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2022-11-10 13:06:07 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!