Bug 31864

Summary: Fix breadcrumbs for each link coming from the new cataloging module home page
Product: Koha Reporter: Lucas Gass <lucas>
Component: Staff interfaceAssignee: Lucas Gass <lucas>
Status: CLOSED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: enhancement    
Priority: P5 - low CC: andrewfh, david, gmcharlt, martin.renvoize
Version: MainKeywords: Academy
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00
Bug Depends on: 31417    
Bug Blocks: 31882    
Attachments: Bug 31864: Correct breadcrumbs for pages in new cataloging module
Bug 31864: (follow-up) Fix breadcrumbs in batchMod and batch_record_mod
Bug 31864: Correct breadcrumbs for pages in new cataloging module
Bug 31864: (follow-up) Fix breadcrumbs in batchMod and batch_record_mod
Bug 31864: Correct breadcrumbs for pages in new cataloging module
Bug 31864: (follow-up) Fix breadcrumbs in batchMod and batch_record_mod

Description Lucas Gass 2022-10-18 22:51:50 UTC
Bug 31162 introduced a new cataloging module homepage, awesome! Most of the breadcrumbs on those pages still point back to Tools, even though the links no longer live in tools. 

We should update the breadcrumbs on each page so they trace back to Cataloging instead of tools.
Comment 1 Lucas Gass 2022-10-18 23:33:20 UTC
Created attachment 142122 [details] [review]
Bug 31864: Correct breadcrumbs for pages in new cataloging module

To test:
1. Apply patch
2. Set system preference 'StockRotation' to enable.
3. Be logged in as a superlibrarian
4. Check the breadcrumbs on the following pages, accessible from the Cataloging module homepage:

barcode-print.tt
label-edit-batch.tt
label-edit-layout.tt
label-edit-profile.tt
label-edit-range.tt
label-edit-template.tt
label-home.tt
label-manage.tt
spinelabel-home.tt
automatic_item_modification_by_age.tt
batchMod-edit.tt
batchMod.tt
batch_delete_records.tt
export.tt
inventory.tt
manage-marc-import.tt
marc_modification_templates.tt
stage-marc-import.tt
stockrotation.tt
upload-images.tt
Comment 2 David Nind 2022-10-19 09:03:04 UTC
I haven't signed off because of Batch item deletion and Batch record modification.

Batch item deletion: The first page is OK, but not when you process something:
1. Enter a barcode (e.g. 39999000011418) in the barcode list.
2. Click Continue.
4. Results screen: still has Tools > Batch item deletion (http://127.0.0.1:8081/cgi-bin/koha/tools/batchMod.pl).

Batch record modification: First page still showing Tools > Batch record modification (with and without and any MARC modification templates setup)

In addition, page titles are still showing the old title - maybe changing these should be a separate bug. To view the page title, hover over the tab in your browser, for example for Batch item deletion: Batch item deletion > Tools > Koha.
Comment 3 Lucas Gass 2022-10-19 22:30:17 UTC
Created attachment 142214 [details] [review]
Bug 31864: (follow-up) Fix breadcrumbs in batchMod and batch_record_mod
Comment 4 Lucas Gass 2022-10-19 22:34:13 UTC
Thanks David! I filed Bug 31882.
Comment 5 David Nind 2022-10-20 02:07:11 UTC
Created attachment 142221 [details] [review]
Bug 31864: Correct breadcrumbs for pages in new cataloging module

To test:
1. Apply patch
2. Set system preference 'StockRotation' to enable.
3. Be logged in as a superlibrarian
4. Check the breadcrumbs on the following pages, accessible from the Cataloging module homepage:

barcode-print.tt
label-edit-batch.tt
label-edit-layout.tt
label-edit-profile.tt
label-edit-range.tt
label-edit-template.tt
label-home.tt
label-manage.tt
spinelabel-home.tt
automatic_item_modification_by_age.tt
batchMod-edit.tt
batchMod.tt
batch_delete_records.tt
export.tt
inventory.tt
manage-marc-import.tt
marc_modification_templates.tt
stage-marc-import.tt
stockrotation.tt
upload-images.tt

Signed-off-by: David Nind <david@davidnind.com>
Comment 6 David Nind 2022-10-20 02:07:15 UTC
Created attachment 142222 [details] [review]
Bug 31864: (follow-up) Fix breadcrumbs in batchMod and batch_record_mod

Signed-off-by: David Nind <david@davidnind.com>
Comment 7 David Nind 2022-10-20 02:07:48 UTC
(In reply to Lucas Gass from comment #4)
> Thanks David! I filed Bug 31882.

Thanks Lucas!
Comment 8 Katrin Fischer 2022-10-21 14:58:48 UTC
Created attachment 142403 [details] [review]
Bug 31864: Correct breadcrumbs for pages in new cataloging module

To test:
1. Apply patch
2. Set system preference 'StockRotation' to enable.
3. Be logged in as a superlibrarian
4. Check the breadcrumbs on the following pages, accessible from the Cataloging module homepage:

barcode-print.tt
label-edit-batch.tt
label-edit-layout.tt
label-edit-profile.tt
label-edit-range.tt
label-edit-template.tt
label-home.tt
label-manage.tt
spinelabel-home.tt
automatic_item_modification_by_age.tt
batchMod-edit.tt
batchMod.tt
batch_delete_records.tt
export.tt
inventory.tt
manage-marc-import.tt
marc_modification_templates.tt
stage-marc-import.tt
stockrotation.tt
upload-images.tt

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 9 Katrin Fischer 2022-10-21 14:58:54 UTC
Created attachment 142404 [details] [review]
Bug 31864: (follow-up) Fix breadcrumbs in batchMod and batch_record_mod

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 10 Martin Renvoize 2022-10-24 14:31:26 UTC
*** Bug 31556 has been marked as a duplicate of this bug. ***
Comment 11 Tomás Cohen Arazi 2022-10-24 14:55:55 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!