Bug 32043

Summary: Circulation alerts can overlap other elements on smaller screens
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: trivial    
Priority: P5 - low CC: david, gmcharlt
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00
Bug Depends on: 30952    
Bug Blocks:    
Attachments: Screenshot of circulation alert
Bug 32043: Circulation alerts can overlap other elements on smaller screens
Bug 32043: Circulation alerts can overlap other elements on smaller screens
Bug 32043: Circulation alerts can overlap other elements on smaller screens

Description Katrin Fischer 2022-10-30 09:32:18 UTC
Created attachment 142807 [details]
Screenshot of circulation alert

When you work on a smaller screen or with a smaller window, the circulation alerts like in the screenshot can overlap with the other elements a bit.

Also: When the element is active, we see a red border and round corners.
Comment 1 Owen Leonard 2022-11-04 17:35:23 UTC
Created attachment 143259 [details] [review]
Bug 32043: Circulation alerts can overlap other elements on smaller screens

This patch makes a minor change to CSS controlling the appearance of the
dialog which appears on the checkout page when a confirmation is
required.

To test, apply the patch and rebuild the staff interface CSS.

Open a patron account for checkout, and submit the barcode of an item
which will require confirmation before the operation can be completed.
For example:

- Item on hold for another patron
- Item waiting for another patron
- Item is checked out to another patron.

The confirmation dialog should have a comfortable margin between it and
the checkout form.
Comment 2 David Nind 2022-11-04 20:47:26 UTC
Created attachment 143291 [details] [review]
Bug 32043: Circulation alerts can overlap other elements on smaller screens

This patch makes a minor change to CSS controlling the appearance of the
dialog which appears on the checkout page when a confirmation is
required.

To test, apply the patch and rebuild the staff interface CSS.

Open a patron account for checkout, and submit the barcode of an item
which will require confirmation before the operation can be completed.
For example:

- Item on hold for another patron
- Item waiting for another patron
- Item is checked out to another patron.

The confirmation dialog should have a comfortable margin between it and
the checkout form.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2022-11-04 20:49:46 UTC
Testing notes:

- This was happening to me even on a large monitor (27") with browser window maximised.

- Another occurrence to test is if you checkout an item to a patron and set the due date in the past.
Comment 4 Katrin Fischer 2022-11-09 23:07:03 UTC
Created attachment 143599 [details] [review]
Bug 32043: Circulation alerts can overlap other elements on smaller screens

This patch makes a minor change to CSS controlling the appearance of the
dialog which appears on the checkout page when a confirmation is
required.

To test, apply the patch and rebuild the staff interface CSS.

Open a patron account for checkout, and submit the barcode of an item
which will require confirmation before the operation can be completed.
For example:

- Item on hold for another patron
- Item waiting for another patron
- Item is checked out to another patron.

The confirmation dialog should have a comfortable margin between it and
the checkout form.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Tomás Cohen Arazi 2022-11-10 13:10:15 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!