Summary: | Label for patron attributes misaligned on patron batch mod | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Staff interface | Assignee: | Matt Blenkinsop <matt.blenkinsop> |
Status: | RESOLVED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | david, gmcharlt, lucas, martin.renvoize, matt.blenkinsop |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.01
|
|
Bug Depends on: | 30952 | ||
Bug Blocks: | 34181 | ||
Attachments: |
Bug 32257 : Label for Patron Attributes Misaligned
Bug 32257: Label for patron attributes misaligned Bug 32257 : Label for Patron Attributes Misaligned Bug 32257: Label for Patron Attributes Misaligned Bug 32257: Label for Patron Attributes Misaligned Bug 32257: Label for patron attributes misaligned Bug 32257: Fix capitalization - Patron Attribute |
Description
Katrin Fischer
2022-11-17 18:41:47 UTC
Created attachment 144210 [details] [review] Bug 32257 : Label for Patron Attributes Misaligned Label has now been realigned to match the format of the fields above. Test Plan: 1) Navigate to Tools > Batch patron modification 2) Add either card or borrower numbers to bring up the edit patrons fields 3) "Patron attributes:" is on the far right and above the select box 4) Apply patch and navigate to same area 5) Observe that the Patron attributes option is aligned to match the fields above Created attachment 144305 [details] [review] Bug 32257: Label for patron attributes misaligned Label has now been realigned to match the format of the fields above. Test plan: 1) Navigate to Tools > Batch patron modification 2) Add either card or borrower numbers to bring up the edit patrons fields 3) "Patron attributes:" is on the far right and above the select box 4) Apply patch and navigate to same area 5) Observe that the Patron attributes option is aligned to match the fields above Signed-off-by: David Nind <david@davidnind.com> Hi Matt. I probably should have marked as Failed QA, but have amended your patch as this is an easy change: 1. We normally use sentence case for field labels: I changed "Patron Attribute" to "Patron attribute". 2. Commit message title: I changed the bug title in the patch, see the development guidelines https://wiki.koha-community.org/wiki/Commit_messages#Subject_line David Thanks for the little fixes in line David.. Great to see a new dev getting welcomed to the community so nicely :) This improves the situation, but there is a remaining alignment issue: When you click on the plus, the Delete link shows far to the right. Matt, could you maybe have another look here? Thx! Looks like there is an empty span tag with 25% width as a placeholder for info hints for each field. I've amended the JQuery to append the Delete button before this span tag Created attachment 144443 [details] [review] Bug 32257 : Label for Patron Attributes Misaligned Label has now been realigned to match the format of the fields above. When clicking to add a new field, the delete button was also misaligned. This has now been reformatted to sit next to the "New" button Test Plan: 1) Navigate to Tools > Batch patron modification 2) Add either card or borrower numbers to bring up the edit patrons fields 3) "Patron attributes:" is on the far right and above the select box. When adding a new field there is a big gap between the Add and Delete buttons 4) Apply patch and navigate to same area 5) Observe that the Patron attributes option is aligned to match the fields above and the gap between the buttons has been removed Matt, everything is good looking great here except your commit title. The QA tool complains about that: * Commit title does not start with 'Bug XXXXX: ' - 32e5a26b389 Can you just change it from 'Bug 32257 ' to 'Bug 32257: ' ? Sorry not sure how I managed to add that space in! Just removed it Created attachment 144452 [details] [review] Bug 32257: Label for Patron Attributes Misaligned Label has now been realigned to match the format of the fields above. When clicking to add a new field, the delete button was also misaligned. This has now been reformatted to sit next to the "New" button Test Plan: 1) Navigate to Tools > Batch patron modification 2) Add either card or borrower numbers to bring up the edit patrons fields 3) "Patron attributes:" is on the far right and above the select box. When adding a new field there is a big gap between the Add and Delete buttons 4) Apply patch and navigate to same area 5) Observe that the Patron attributes option is aligned to match the fields above and the gap between the buttons has been removed Created attachment 144453 [details] [review] Bug 32257: Label for Patron Attributes Misaligned Label has now been realigned to match the format of the fields above. When clicking to add a new field, the delete button was also misaligned. This has now been reformatted to sit next to the "New" button Test Plan: 1) Navigate to Tools > Batch patron modification 2) Add either card or borrower numbers to bring up the edit patrons fields 3) "Patron attributes:" is on the far right and above the select box. When adding a new field there is a big gap between the Add and Delete buttons 4) Apply patch and navigate to same area 5) Observe that the Patron attributes option is aligned to match the fields above and the gap between the buttons has been removed Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Comment on attachment 144453 [details] [review] Bug 32257: Label for Patron Attributes Misaligned Review of attachment 144453 [details] [review]: ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt @@ +368,5 @@ > [% END %] > [% IF ( patron_attributes_codes ) %] > <li class="attributes"> > + <label style="width:auto;"> > + <span>Patron Attribute:</span> This is meant well, but Koha uses sentence case everywhere (it's coding guideline too) :) I'll fix in a tiny follow-up. Created attachment 144489 [details] [review] Bug 32257: Label for patron attributes misaligned Label has now been realigned to match the format of the fields above. When clicking to add a new field, the delete button was also misaligned. This has now been reformatted to sit next to the "New" button Test Plan: 1) Navigate to Tools > Batch patron modification 2) Add either card or borrower numbers to bring up the edit patrons fields 3) "Patron attributes:" is on the far right and above the select box. When adding a new field there is a big gap between the Add and Delete buttons 4) Apply patch and navigate to same area 5) Observe that the Patron attributes option is aligned to match the fields above and the gap between the buttons has been removed Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 144490 [details] [review] Bug 32257: Fix capitalization - Patron Attribute Pushed to master for 23.05. Nice work everyone, thanks! Nice work everyone! Pushed to 22.11.x for the next release |