Bug 32293

Summary: Terminology: Some budgets are not defined in item records
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: TemplatesAssignee: Katrin Fischer <katrin.fischer>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: trivial    
Priority: P5 - low CC: david, lucas
Version: MainKeywords: Academy
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: String patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.04
Bug Depends on: 32888    
Bug Blocks:    
Attachments: Bug 32293: Fix terminology in warning when creating orders from staged file
Bug 32293: Fix terminology in warning when creating orders from staged file
Bug 32293: Fix terminology in warning when creating orders from staged file

Description Katrin Fischer 2022-11-19 19:06:40 UTC
The error message should use 'funds' not 'budgets':

koha-tmpl/intranet-tmpl/prog/js/addorderiso2709.js:            
alert( __("Some budgets are not defined in item records") )

I think that this one appears when you try to add orders from a staged file, but leave the fund empty.
Comment 1 Katrin Fischer 2023-02-05 01:58:25 UTC
Created attachment 146188 [details] [review]
Bug 32293: Fix terminology in warning when creating orders from staged file

When you are ordering from a staged file and the
fund is missing, there is a warning:

Some budgets are not defined in item records

Budgets shoudl be funds here.

To test:
* Add a new basket
* Add an order from a staged file or from a file
* Leave the fund values of some selected items empty
* Make sure default fund entry is also empty
* Warning message should be triggered on saving
* Apply patch, repeat, verify it is correct now.
Comment 2 Katrin Fischer 2023-02-05 01:59:16 UTC
There is currently an issue in bug 32888 that means we can no longer trigger that warning/message as it just uses the first fund found.
Comment 3 David Nind 2023-02-07 20:27:49 UTC
Created attachment 146358 [details] [review]
Bug 32293: Fix terminology in warning when creating orders from staged file

When you are ordering from a staged file and the
fund is missing, there is a warning:

Some budgets are not defined in item records

Budgets shoudl be funds here.

To test:
* Add a new basket
* Add an order from a staged file or from a file
* Leave the fund values of some selected items empty
* Make sure default fund entry is also empty
* Warning message should be triggered on saving
* Apply patch, repeat, verify it is correct now.

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2023-02-07 20:28:48 UTC
As the warning can't be triggered until there is a patch for bug 32888, I tested by reviewing the diff.
Comment 5 Jonathan Druart 2023-02-23 14:43:48 UTC
Created attachment 147240 [details] [review]
Bug 32293: Fix terminology in warning when creating orders from staged file

When you are ordering from a staged file and the
fund is missing, there is a warning:

Some budgets are not defined in item records

Budgets shoudl be funds here.

To test:
* Add a new basket
* Add an order from a staged file or from a file
* Leave the fund values of some selected items empty
* Make sure default fund entry is also empty
* Warning message should be triggered on saving
* Apply patch, repeat, verify it is correct now.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 6 Tomás Cohen Arazi 2023-02-27 14:42:17 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 7 Matt Blenkinsop 2023-03-01 09:51:14 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 8 Lucas Gass 2023-03-10 14:22:41 UTC
Missing dependencies for 22.05.x, no backport