Bug 32562

Summary: Reindent the about page template
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: RESOLVED FIXED QA Contact: Kyle M Hall <kyle>
Severity: minor    
Priority: P5 - low CC: kyle, martin.renvoize
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.03
Bug Depends on:    
Bug Blocks: 32571    
Attachments: Bug 32562: Reindent the about page template
Bug 32562: (follow-up) Add markup comments
Bug 32562: Reindent the about page template
Bug 32562: (follow-up) Add markup comments
Bug 32562: Reindent the about page template
Bug 32562: (follow-up) Add markup comments

Description Owen Leonard 2023-01-04 12:08:58 UTC
I would like to reformat the about page template (about.tt) in the staff interface so that it has consistent spacing and indentation.
Comment 1 Owen Leonard 2023-01-05 12:01:40 UTC
Created attachment 145055 [details] [review]
Bug 32562: Reindent the about page template

This patch reindents the about page template so that it has consistent
indentation. These changes should have no visible effect on the page.

To test, apply the patch and view the about page. Everything should look
normal. All tabs should work correctly.

Viewing the diff while ignoring whitespace changes should show only
places where a line break was added.
Comment 2 Owen Leonard 2023-01-05 12:01:44 UTC
Created attachment 145056 [details] [review]
Bug 32562: (follow-up) Add markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the page's appearance or
functionality.
Comment 3 Lucas Gass 2023-01-05 18:54:22 UTC
Created attachment 145071 [details] [review]
Bug 32562: Reindent the about page template

This patch reindents the about page template so that it has consistent
indentation. These changes should have no visible effect on the page.

To test, apply the patch and view the about page. Everything should look
normal. All tabs should work correctly.

Viewing the diff while ignoring whitespace changes should show only
places where a line break was added.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 4 Lucas Gass 2023-01-05 18:54:25 UTC
Created attachment 145072 [details] [review]
Bug 32562: (follow-up) Add markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the page's appearance or
functionality.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 5 Kyle M Hall 2023-01-06 16:13:42 UTC
Created attachment 145088 [details] [review]
Bug 32562: Reindent the about page template

This patch reindents the about page template so that it has consistent
indentation. These changes should have no visible effect on the page.

To test, apply the patch and view the about page. Everything should look
normal. All tabs should work correctly.

Viewing the diff while ignoring whitespace changes should show only
places where a line break was added.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 6 Kyle M Hall 2023-01-06 16:13:53 UTC
Created attachment 145089 [details] [review]
Bug 32562: (follow-up) Add markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the page's appearance or
functionality.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 7 Tomás Cohen Arazi 2023-01-27 19:19:38 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 8 Matt Blenkinsop 2023-01-31 14:33:43 UTC
Nice work everyone!

Pushed to stable for 22.11.x