Summary: | UI/Form/Builder/Item.t is failing randomly | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Test Suite | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | RESOLVED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | tomascohen |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.05
|
|
Bug Depends on: | 28445 | ||
Bug Blocks: | 25551 | ||
Attachments: |
Bug 32710: Try to prevent UI/Form/Builder/Item.t to fail randomly
Bug 32710: Try to prevent UI/Form/Builder/Item.t to fail randomly |
Description
Jonathan Druart
2023-01-24 15:11:20 UTC
koha_1 | # Failed test 'Item types should be sorted by description and an empty entry should be shown' koha_1 | # at t/db_dependent/Koha/UI/Form/Builder/Item.t line 135. koha_1 | # Structures begin differing at: koha_1 | # $got->[11] = 'qbZe6s__5Y' koha_1 | # $expected->[11] = 'REF' koha_1 | # Looks like you failed 1 test of 2. koha_1 | koha_1 | # Failed test 'itemtypes' koha_1 | # at t/db_dependent/Koha/UI/Form/Builder/Item.t line 143. koha_1 | # Looks like you failed 1 test of 5. koha_1 | koha_1 | # Failed test 'authorised values' koha_1 | # at t/db_dependent/Koha/UI/Form/Builder/Item.t line 144. koha_1 | # Looks like you failed 1 test of 9. koha_1 | [16:48:09] t/db_dependent/Koha/UI/Form/Builder/Item.t Koha_Master/2449 Created attachment 149018 [details] [review] Bug 32710: Try to prevent UI/Form/Builder/Item.t to fail randomly See the FIXME, and commit 77a34e099a9f3bcef2076a4170e8c8d843c403eb Actually we are doing the trick (of removing _) before we are creating another itemtype, we need to do it right before we are comparing. Test plan: Run in a loop, be patient, it failed for me (without the patch) at run 245 Created attachment 149020 [details] [review] Bug 32710: Try to prevent UI/Form/Builder/Item.t to fail randomly See the FIXME, and commit 77a34e099a9f3bcef2076a4170e8c8d843c403eb Actually we are doing the trick (of removing _) before we are creating another itemtype, we need to do it right before we are comparing. Test plan: Run in a loop, be patient, it failed for me (without the patch) at run 245 Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Pushed to master for 23.05. Nice work everyone, thanks! Nice work everyone! Pushed to stable for 22.11.x |