Bug 32859

Summary: Fix cataloguing/value_builder/unimarc_field_128b.pl
Product: Koha Reporter: Julian Maurice <julian.maurice>
Component: CatalogingAssignee: Julian Maurice <julian.maurice>
Status: RESOLVED FIXED QA Contact: Testopia <testopia>
Severity: trivial    
Priority: P5 - low CC: david, m.de.rooy
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.05
Bug Depends on:    
Bug Blocks: 30975    
Attachments: Bug 32859: Fix cataloguing/value_builder/unimarc_field_128b.pl
Bug 32859: Fix cataloguing/value_builder/unimarc_field_128b.pl
Bug 32859: Fix cataloguing/value_builder/unimarc_field_128b.pl
Bug 32859: Fix cataloguing/value_builder/unimarc_field_128b.pl

Description Julian Maurice 2023-02-03 13:36:39 UTC
This is part of the refactoring happening in bug 30975
Comment 1 Julian Maurice 2023-02-03 13:37:14 UTC
Created attachment 146124 [details] [review]
Bug 32859: Fix cataloguing/value_builder/unimarc_field_128b.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before
Comment 2 Julian Maurice 2023-02-17 10:16:29 UTC
Created attachment 146795 [details] [review]
Bug 32859: Fix cataloguing/value_builder/unimarc_field_128b.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before
Comment 3 David Nind 2023-03-26 17:44:00 UTC
Created attachment 148727 [details] [review]
Bug 32859: Fix cataloguing/value_builder/unimarc_field_128b.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2023-03-26 17:51:02 UTC
How I tested
~~~~~~~~~~~~

1. Add the unimarc_field_128b.pl plugin to subfield 128$b for the default UNIMARC bibliographic framework in KTD.
2. Change 'Managed in tab' from 'Ignore' to 1'1'.
3. Edit a bibliographic record.
4. Select the tag editor for the subfield.
5. Options and values should be the same before and after the patch is applied.

Description
~~~~~~~~~~~

This is a standard UNIMARC value builder for a subfield - it displays a form to select the values that make up the subfield.

Note: Subfield 128$b is obsolete ([Obsolete] Instruments or Voices for Ensembles).
Comment 5 Nick Clemens (kidclamp) 2023-03-29 08:37:28 UTC
Created attachment 148877 [details] [review]
Bug 32859: Fix cataloguing/value_builder/unimarc_field_128b.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 6 Tomás Cohen Arazi 2023-03-30 10:32:25 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 7 Matt Blenkinsop 2023-04-11 11:12:35 UTC
Nice work everyone!

Pushed to stable for 22.11.x