Bug 32867

Summary: Clean up cataloguing/value_builder/unimarc_field_146i.pl
Product: Koha Reporter: Julian Maurice <julian.maurice>
Component: CatalogingAssignee: Julian Maurice <julian.maurice>
Status: RESOLVED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: trivial    
Priority: P5 - low CC: david, m.de.rooy
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.06
Bug Depends on:    
Bug Blocks: 30975    
Attachments: Bug 32867: Fix cataloguing/value_builder/unimarc_field_146i.pl
Bug 32867: Fix cataloguing/value_builder/unimarc_field_146i.pl
Bug 32867: Fix cataloguing/value_builder/unimarc_field_146i.pl

Description Julian Maurice 2023-02-03 13:57:37 UTC
This is part of the refactoring happening in bug 30975
Comment 1 Julian Maurice 2023-02-03 13:58:06 UTC
Created attachment 146132 [details] [review]
Bug 32867: Fix cataloguing/value_builder/unimarc_field_146i.pl

Remove unnecessary call to event.preventDefault()

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before
Comment 2 Julian Maurice 2023-02-06 15:50:28 UTC
This one is actually only a cleanup patch that is not needed for bug 30975, but bug 30975 is needed for the cleanup to be possible.
Comment 3 David Nind 2023-03-28 19:01:28 UTC
Created attachment 148845 [details] [review]
Bug 32867: Fix cataloguing/value_builder/unimarc_field_146i.pl

Remove unnecessary call to event.preventDefault()

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2023-03-28 19:04:45 UTC
How I tested
~~~~~~~~~~~~

1. Applied bug 30975 (interactive, commented out the first patch) - this takes a while as you have to say yes to all the dependent bugs.
2. Added the plugin unimarc_field_146i.pl to subfield 146$i for the default UNIMARC bibliographic framework in KTD.
3. Edit a bibliographic record.
4. Select the tag editor for the subfield.
5. Options and values should be the same before and after the patch is applied.

Bonus: With bug 30975 applied, cloning subfields and using the tag editor on the cloned subfield now works as expected!

Description
~~~~~~~~~~~

This is a standard UNIMARC value builder for a subfield - it displays a form to select the values that make up the subfield.
Comment 5 Katrin Fischer 2023-04-22 21:26:28 UTC
Created attachment 150097 [details] [review]
Bug 32867: Fix cataloguing/value_builder/unimarc_field_146i.pl

Remove unnecessary call to event.preventDefault()

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Tomás Cohen Arazi 2023-04-24 13:49:25 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 7 Jacob O'Mara 2023-05-10 12:54:04 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.